Re: [dpdk-dev] [PATCH v3] net/bonding: fix slave add for mode 4

2018-06-01 Thread Radu Nicolau
On 6/1/2018 1:05 AM, Chas Williams wrote: It's not clear to me that the issue here is the bonding slave add. You can only add started PMDs.  When a PMD dev start is complete, the PMD should have a valid link state and the link properties should be valid.  A few of the PMDs are very good about

Re: [dpdk-dev] [PATCH v3] net/bonding: fix slave add for mode 4

2018-05-31 Thread Chas Williams
It's not clear to me that the issue here is the bonding slave add. You can only add started PMDs. When a PMD dev start is complete, the PMD should have a valid link state and the link properties should be valid. A few of the PMDs are very good about this, particularly the ones with LSC interrupts

[dpdk-dev] [PATCH v3] net/bonding: fix slave add for mode 4

2018-05-31 Thread Radu Nicolau
Add a call to rte_eth_link_get_nowait on every slave to update the internal link status struct. Otherwise slave add will fail for mode 4 if the ports are all stopped but only one of them checked. Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions") Bugzilla ID: 52 Signed-off-b