Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-16 Thread Tasnim Bashar
Shnaiderman ; Fady > Bader ; Ophir Munk > Subject: Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle > > 16/06/2020 20:53, Tasnim Bashar: > > > From: Thomas Monjalon > > > 02/06/2020 04:00, Tasnim Bashar: > > > > Casting thread ID to handle i

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-16 Thread Thomas Monjalon
16/06/2020 20:53, Tasnim Bashar: > > From: Thomas Monjalon > > 02/06/2020 04:00, Tasnim Bashar: > > > Casting thread ID to handle is not accurate way to get thread handle. > > > Need to use OpenThread function to get thread handle from thread ID. > > > > > > pthread_setaffinity_np and pthread_geta

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-16 Thread Tasnim Bashar
> From: Thomas Monjalon > 02/06/2020 04:00, Tasnim Bashar: > > #define pthread_setaffinity_np(thread, size, cpuset) \ > > - eal_set_thread_affinity_mask(thread, (unsigned long *) cpuset) > > + eal_set_thread_affinity_mask(thread, cpuset) > > #define pthread_getaffinity_np(thread, size, cpuse

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-16 Thread Tasnim Bashar
> From: Thomas Monjalon > 02/06/2020 04:00, Tasnim Bashar: > > Casting thread ID to handle is not accurate way to get thread handle. > > Need to use OpenThread function to get thread handle from thread ID. > > > > pthread_setaffinity_np and pthread_getaffinity_np functions for > > Windows are affe

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-15 Thread Thomas Monjalon
02/06/2020 04:00, Tasnim Bashar: > #define pthread_setaffinity_np(thread, size, cpuset) \ > - eal_set_thread_affinity_mask(thread, (unsigned long *) cpuset) > + eal_set_thread_affinity_mask(thread, cpuset) > #define pthread_getaffinity_np(thread, size, cpuset) \ > - eal_get_thread_aff

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-15 Thread Thomas Monjalon
02/06/2020 04:00, Tasnim Bashar: > Casting thread ID to handle is not accurate way to get thread handle. > Need to use OpenThread function to get thread handle from thread ID. > > pthread_setaffinity_np and pthread_getaffinity_np functions > for Windows are affected because of it. > > Signed-off-

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-12 Thread Thomas Monjalon
12/06/2020 18:22, Tasnim Bashar: > From: Thomas Monjalon > > 02/06/2020 04:00, Tasnim Bashar: > > > --- a/lib/librte_eal/windows/include/rte_windows.h > > > +++ b/lib/librte_eal/windows/include/rte_windows.h > > > @@ -29,6 +29,7 @@ > > > #define INITGUID > > > #endif > > > #include > > > +#inc

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-12 Thread Tasnim Bashar
m; > pallavi.ka...@intel.com; ranjit.me...@intel.com; ocard...@microsoft.com; > navas...@linux.microsoft.com; dmitry.kozl...@gmail.com; Tal Shnaiderman > ; Fady Bader ; Ophir Munk > > Subject: Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle > > 02/06/2020 04:00, Tas

Re: [dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-11 Thread Thomas Monjalon
02/06/2020 04:00, Tasnim Bashar: > --- a/lib/librte_eal/windows/include/rte_windows.h > +++ b/lib/librte_eal/windows/include/rte_windows.h > @@ -29,6 +29,7 @@ > #define INITGUID > #endif > #include > +#include Why do you need adding rte_log in rte_windows?

[dpdk-dev] [PATCH v3] eal/windows: fix invalid thread handle

2020-06-01 Thread Tasnim Bashar
Casting thread ID to handle is not accurate way to get thread handle. Need to use OpenThread function to get thread handle from thread ID. pthread_setaffinity_np and pthread_getaffinity_np functions for Windows are affected because of it. Signed-off-by: Tasnim Bashar --- v3: WA to remove warning