Re: [dpdk-dev] [PATCH v3] eal/service: improve error checking of coremasks

2018-07-26 Thread Thomas Monjalon
Hi Harry, Are you OK to make a v4? 13/07/2018 19:33, Thomas Monjalon: > 13/07/2018 19:25, Harry van Haaren: > > v3: > > - Use WARNING instead of ERR log level (Vipin) > > - Put strings on one line for grep-ability (Harry) > > We can consider it is OK to have sentences on different lines. > Who

Re: [dpdk-dev] [PATCH v3] eal/service: improve error checking of coremasks

2018-07-13 Thread Varghese, Vipin
Thanks for the change in log level Acked-by: Vipin Varghese > -Original Message- > From: Van Haaren, Harry > Sent: Friday, July 13, 2018 10:56 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; > tho...@monjalon.net; Varghese, Vipin > Subject: [PATCH v3] eal/service: improve error checking

Re: [dpdk-dev] [PATCH v3] eal/service: improve error checking of coremasks

2018-07-13 Thread Thomas Monjalon
13/07/2018 19:25, Harry van Haaren: > v3: > - Use WARNING instead of ERR log level (Vipin) > - Put strings on one line for grep-ability (Harry) We can consider it is OK to have sentences on different lines. Who is grepping 2 sentences at once? > v2, thanks for review: > - Consistency in message e

[dpdk-dev] [PATCH v3] eal/service: improve error checking of coremasks

2018-07-13 Thread Harry van Haaren
This commit improves the error checking performed on the core masks (or lists) of the service cores, in particular with respect to the data-plane (RTE) cores of DPDK. With this commit, invalid configurations are detected at runtime, and warning messages are printed to inform the user. For example