Re: [dpdk-dev] [PATCH v3] app/proc-info: fix port mask parse issue

2018-11-16 Thread Burakov, Anatoly
On 16-Nov-18 10:15 AM, Burakov, Anatoly wrote: On 07-Nov-18 6:10 AM, Li Han wrote: parse_portmask return type is int,but global variable "enabled_port_mask" type is uint32_t.so in proc_info_parse_args function,when parse_portmask return -1,"enabled_port_mask" will get a huge value and "if (enabl

Re: [dpdk-dev] [PATCH v3] app/proc-info: fix port mask parse issue

2018-11-16 Thread Burakov, Anatoly
On 07-Nov-18 6:10 AM, Li Han wrote: parse_portmask return type is int,but global variable "enabled_port_mask" type is uint32_t.so in proc_info_parse_args function,when parse_portmask return -1,"enabled_port_mask" will get a huge value and "if (enabled_port_mask == 0)" will never happen. Fixes: 2

Re: [dpdk-dev] [PATCH v3] app/proc-info: fix port mask parse issue

2018-11-14 Thread Burakov, Anatoly
On 14-Nov-18 3:10 AM, Thomas Monjalon wrote: Hi, 07/11/2018 07:10, Li Han: parse_portmask return type is int,but global variable "enabled_port_mask" type is uint32_t.so in proc_info_parse_args function,when parse_portmask return -1,"enabled_port_mask" will get a huge value and "if (enabled_port

Re: [dpdk-dev] [PATCH v3] app/proc-info: fix port mask parse issue

2018-11-13 Thread Thomas Monjalon
Hi, 07/11/2018 07:10, Li Han: > parse_portmask return type is int,but global variable > "enabled_port_mask" type is uint32_t.so in proc_info_parse_args > function,when parse_portmask return -1,"enabled_port_mask" will > get a huge value and "if (enabled_port_mask == 0)" will never happen. > > Fix

Re: [dpdk-dev] [PATCH v3] app/proc-info: fix port mask parse issue

2018-11-07 Thread Pattan, Reshma
> -Original Message- > From: Li Han [mailto:han@zte.com.cn] > Sent: Wednesday, November 7, 2018 6:10 AM > To: Pattan, Reshma > Cc: dev@dpdk.org; Li Han > Subject: [PATCH v3] [dpdk-dev] app/proc-info: fix port mask parse issue > > parse_portmask return type is int,but global variab

[dpdk-dev] [PATCH v3] app/proc-info: fix port mask parse issue

2018-11-06 Thread Li Han
parse_portmask return type is int,but global variable "enabled_port_mask" type is uint32_t.so in proc_info_parse_args function,when parse_portmask return -1,"enabled_port_mask" will get a huge value and "if (enabled_port_mask == 0)" will never happen. Fixes: 22561383ea17 ("app: replace dump_cfg by