Re: [dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()

2019-10-17 Thread David Marchand
On Tue, Oct 8, 2019 at 5:16 PM Stephen Hemminger wrote: > > On Tue, 8 Oct 2019 09:36:49 +0100 > Bruce Richardson wrote: > > > On Mon, Oct 07, 2019 at 04:18:54PM -0700, Stephen Hemminger wrote: > > > On Mon, 07 Oct 2019 08:40:05 -0700 Jim Harris > > > wrote: > > > > > > > This code was added 7+ y

Re: [dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()

2019-10-08 Thread Stephen Hemminger
On Tue, 8 Oct 2019 09:36:49 +0100 Bruce Richardson wrote: > On Mon, Oct 07, 2019 at 04:18:54PM -0700, Stephen Hemminger wrote: > > On Mon, 07 Oct 2019 08:40:05 -0700 Jim Harris > > wrote: > > > > > This code was added 7+ years ago: > > > > > > commit fb022b85bae4 ("timer: check TSC reliabili

Re: [dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()

2019-10-08 Thread Bruce Richardson
On Mon, Oct 07, 2019 at 04:18:54PM -0700, Stephen Hemminger wrote: > On Mon, 07 Oct 2019 08:40:05 -0700 Jim Harris > wrote: > > > This code was added 7+ years ago: > > > > commit fb022b85bae4 ("timer: check TSC reliability") > > > > presumably when variant TSCs were still somewhat common? But

Re: [dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()

2019-10-07 Thread Stephen Hemminger
On Mon, 07 Oct 2019 08:40:05 -0700 Jim Harris wrote: > This code was added 7+ years ago: > > commit fb022b85bae4 ("timer: check TSC reliability") > > presumably when variant TSCs were still somewhat > common? But this code doesn't do anything except print > a warning, and the warning doesn't g

[dpdk-dev] [PATCH v2 RESEND] timer: remove check_tsc_flags()

2019-10-07 Thread Jim Harris
This code was added 7+ years ago: commit fb022b85bae4 ("timer: check TSC reliability") presumably when variant TSCs were still somewhat common? But this code doesn't do anything except print a warning, and the warning doesn't give any kind of advice to the user, so let's just remove it. While t