Re: [dpdk-dev] [PATCH v2 7/7] net/mlx4: separate Tx for multi-segments

2017-10-30 Thread Ophir Munk
Hi, Please see inline. On Wednesday, October 25, 2017 7:50 PM Adrien Mazarguil wrote: > > Hi Ophir, > > On Mon, Oct 23, 2017 at 02:22:00PM +, Ophir Munk wrote: > > This commit optimizes handling of one segment and calls a dedicated > > function for handling multi segments > > > > Signed-off-

Re: [dpdk-dev] [PATCH v2 7/7] net/mlx4: separate Tx for multi-segments

2017-10-25 Thread Adrien Mazarguil
Hi Ophir, On Mon, Oct 23, 2017 at 02:22:00PM +, Ophir Munk wrote: > This commit optimizes handling of one segment and calls a > dedicated function for handling multi segments > > Signed-off-by: Ophir Munk While it indeed moves the code to a separate function I'm not sure by how much it impr

[dpdk-dev] [PATCH v2 7/7] net/mlx4: separate Tx for multi-segments

2017-10-23 Thread Ophir Munk
This commit optimizes handling of one segment and calls a dedicated function for handling multi segments Signed-off-by: Ophir Munk --- drivers/net/mlx4/mlx4_rxtx.c | 284 +++ 1 file changed, 154 insertions(+), 130 deletions(-) diff --git a/drivers/net/mlx