Re: [dpdk-dev] [PATCH v2 6/9] app/procinfo: add code for debug crypto

2018-10-29 Thread Varghese, Vipin
Hi Stepehen, > > > This is a very big macro, better have static function for this instead of > macro. > > > > > > > There are two thoughts in choosing MACRO over function. > > 1. The information need to display in certain format within the same > > context. > > 2. As the API are modified, co lo

Re: [dpdk-dev] [PATCH v2 6/9] app/procinfo: add code for debug crypto

2018-10-28 Thread Stephen Hemminger
On Sat, 27 Oct 2018 04:42:19 + "Varghese, Vipin" wrote: > Hi, > > > > > --- > > + struct rte_cryptodev_info dev_info = {0}; > > + struct rte_cryptodev_stats stats = {0}; > > + > > > > Memset for initialization as mentioned in other patch. > > > > Yes, I will correc

Re: [dpdk-dev] [PATCH v2 6/9] app/procinfo: add code for debug crypto

2018-10-26 Thread Varghese, Vipin
Hi, > --- > + struct rte_cryptodev_info dev_info = {0}; > + struct rte_cryptodev_stats stats = {0}; > + > > Memset for initialization as mentioned in other patch. > Yes, I will correct the same as certain compiler flag combination will treat this as incorrect use. >

Re: [dpdk-dev] [PATCH v2 6/9] app/procinfo: add code for debug crypto

2018-10-26 Thread Varghese, Vipin
Hi Reshma, > > +"\t -- id (%u) flags (0x%"PRIx64") socket (%d)\n" > +"\t -- queue pairs (%d)\n", > +rte_cryptodev_name_get(i), > +dev_info.driver_name, dev_info.driver_id, > +dev_info.feature_f

Re: [dpdk-dev] [PATCH v2 6/9] app/procinfo: add code for debug crypto

2018-10-26 Thread Pattan, Reshma
Hi, -Original Message- From: Varghese, Vipin + "\t -- id (%u) flags (0x%"PRIx64") socket (%d)\n" + "\t -- queue pairs (%d)\n", + rte_cryptodev_name_get(i), + dev_info.driver_name, dev_info.driver_id, +

Re: [dpdk-dev] [PATCH v2 6/9] app/procinfo: add code for debug crypto

2018-10-26 Thread Pattan, Reshma
Hi -Original Message- From: Varghese, Vipin --- + struct rte_cryptodev_info dev_info = {0}; + struct rte_cryptodev_stats stats = {0}; + Memset for initialization as mentioned in other patch. + +#define DSP_CRYPTO_FLAG(x) do { \ +printf(" - feature flags\n")

[dpdk-dev] [PATCH v2 6/9] app/procinfo: add code for debug crypto

2018-10-23 Thread Vipin Varghese
Function debug_crypto is used for displaying the crypto PMD under the primary process. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 70 +++- 1 file changed, 69 insertions(+), 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main