Re: [dpdk-dev] [PATCH v2 5/5] net/mlx5: fix non-dv compilation errors

2020-11-14 Thread Gregory Etelson
> 14/11/2020 19:31, Gregory Etelson: > > > 14/11/2020 18:41, Gregory Etelson: > > > > > 13/11/2020 15:52, Gregory Etelson: > > > > > > + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data- > > > >group, > > > > > > + &flow_table, grp_info, > > > > > > +

Re: [dpdk-dev] [PATCH v2 5/5] net/mlx5: fix non-dv compilation errors

2020-11-14 Thread Thomas Monjalon
14/11/2020 19:31, Gregory Etelson: > > 14/11/2020 18:41, Gregory Etelson: > > > > 13/11/2020 15:52, Gregory Etelson: > > > > > + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data- > > >group, > > > > > + &flow_table, grp_info, > > > > > + error); > > >

Re: [dpdk-dev] [PATCH v2 5/5] net/mlx5: fix non-dv compilation errors

2020-11-14 Thread Gregory Etelson
> 14/11/2020 18:41, Gregory Etelson: > > > 13/11/2020 15:52, Gregory Etelson: > > > > + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data- > >group, > > > > + &flow_table, grp_info, > > > > + error); > > > > > > The parameter grp_info is a struct passe

Re: [dpdk-dev] [PATCH v2 5/5] net/mlx5: fix non-dv compilation errors

2020-11-14 Thread Thomas Monjalon
14/11/2020 18:41, Gregory Etelson: > > 13/11/2020 15:52, Gregory Etelson: > > > + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data->group, > > > + &flow_table, grp_info, error); > > > > The parameter grp_info is a struct passed as value. > > I believ

Re: [dpdk-dev] [PATCH v2 5/5] net/mlx5: fix non-dv compilation errors

2020-11-14 Thread Gregory Etelson
> 13/11/2020 15:52, Gregory Etelson: > > + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data->group, > > + &flow_table, grp_info, error); > > The parameter grp_info is a struct passed as value. > I believe it should be passed as a pointer. struct flo

Re: [dpdk-dev] [PATCH v2 5/5] net/mlx5: fix non-dv compilation errors

2020-11-14 Thread Thomas Monjalon
13/11/2020 15:52, Gregory Etelson: > + ret = mlx5_flow_group_to_table(dev, tunnel, jump_data->group, > + &flow_table, grp_info, error); The parameter grp_info is a struct passed as value. I believe it should be passed as a pointer. I see some other funct

[dpdk-dev] [PATCH v2 5/5] net/mlx5: fix non-dv compilation errors

2020-11-13 Thread Gregory Etelson
ipools used for tunnel offload are restricted to dv enabled code only since 1d1248d452ff, while the rest of the tunnel offload API did not have compilation limitations. As the results, PMD compilation failed on non-dv setups. Current patch groups tunnel offload code in dv enabled code area and pro