Re: [dpdk-dev] [PATCH v2 4/7] ethdev: change allmulticast callbacks to return status

On 9/26/2019 3:00 AM, Yang, Qiming wrote: > [snip] ... > > Hi, Andrew > I think it's no need to define a 'ret'. > Return -EAGAIN and return 0 is enough. Hi Qiming, I have already merged the patchset to the next-net, what you have mentioned looks like a minor issue, would you be OK with as it is?

Re: [dpdk-dev] [PATCH v2 4/7] ethdev: change allmulticast callbacks to return status

[snip] ... Hi, Andrew I think it's no need to define a 'ret'. Return -EAGAIN and return 0 is enough. Qiming static int diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 46ed70816..c699f3ef0 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c

[dpdk-dev] [PATCH v2 4/7] ethdev: change allmulticast callbacks to return status

m> <1569329773-10185-1-git-send-email-arybche...@solarflare.com> From: Ivan Ilchenko Enabling/disabling of allmulticast mode is not always successful and it should be taken into account to be able to handle it properly. When correct return status is unclear from driver code, -EAGAIN is used.