Re: [dpdk-dev] [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters

2018-04-03 Thread Remy Horton
On 28/03/2018 08:18, Shreyansh Jain wrote: [..] Can the change for burst size too be accommodated in this patch? I looked through them and they might not be as trivial as the change above - but if that is incorporated in this, it might serve as example for other applications. Testpmd doesn't r

Re: [dpdk-dev] [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters

2018-04-03 Thread Remy Horton
On 31/03/2018 01:01, Thomas Monjalon wrote: [..] uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; /**< Number of RX descriptors. */ uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; /**< Number of TX descriptors. */ These doxygen comments in the middle of the code are totally useless. Did wonder why

Re: [dpdk-dev] [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters

2018-03-30 Thread Thomas Monjalon
21/03/2018 15:27, Remy Horton: > /* > * Configurable number of RX/TX ring descriptors. Configurable, really? > + * Defaults are supplied by drivers via ethdev. And fallback values are in ethdev. > */ > -#define RTE_TEST_RX_DESC_DEFAULT 1024 > -#define RTE_TEST_TX_DESC_DEFAULT 1024 > +#defi

Re: [dpdk-dev] [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters

2018-03-28 Thread Shreyansh Jain
Hello Remy, > -Original Message- > From: Remy Horton [mailto:remy.hor...@intel.com] > Sent: Wednesday, March 21, 2018 7:58 PM > To: dev@dpdk.org > Cc: John McNamara ; Wenzhuo Lu > ; Jingjing Wu ; Qi Zhang > ; Beilei Xing ; Shreyansh > Jain ; Thomas Monjalon > Subject: [PATCH v2 4/4] testp

[dpdk-dev] [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters

2018-03-21 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows testpmd to make use of per-PMD tuned parameter values. Signed-off-by: Remy Horton ---