Re: [dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action items support

2018-04-06 Thread Mohammad Abdul Awal
On 06/04/2018 16:57, Thomas Monjalon wrote: 06/04/2018 15:47, Mohammad Abdul Awal: On 05/04/2018 17:49, Thomas Monjalon wrote: 05/04/2018 15:51, Declan Doherty: +struct rte_flow_item_metadata { + uint32_t id;/**< field identifier */ + uint32_t size; /**< fiel

Re: [dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action items support

2018-04-06 Thread Thomas Monjalon
06/04/2018 15:47, Mohammad Abdul Awal: > > On 05/04/2018 17:49, Thomas Monjalon wrote: > > 05/04/2018 15:51, Declan Doherty: > >> +struct rte_flow_item_metadata { > >> + uint32_t id;/**< field identifier */ > >> + uint32_t size; /**< field size */ > >> + uint

Re: [dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action items support

2018-04-06 Thread Mohammad Abdul Awal
On 05/04/2018 17:49, Thomas Monjalon wrote: 05/04/2018 15:51, Declan Doherty: +struct rte_flow_item_metadata { + uint32_t id;/**< field identifier */ + uint32_t size; /**< field size */ + uint8_t bytes[];/**< field value */ +}; Spotted C99 syntax

Re: [dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action items support

2018-04-06 Thread Adrien Mazarguil
On Thu, Apr 05, 2018 at 06:49:32PM +0200, Thomas Monjalon wrote: > 05/04/2018 15:51, Declan Doherty: > > +struct rte_flow_item_metadata { > > + uint32_t id;/**< field identifier */ > > + uint32_t size; /**< field size */ > > + uint8_t bytes[];/**< fiel

Re: [dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action items support

2018-04-05 Thread Thomas Monjalon
05/04/2018 15:51, Declan Doherty: > +struct rte_flow_item_metadata { > + uint32_t id;/**< field identifier */ > + uint32_t size; /**< field size */ > + uint8_t bytes[];/**< field value */ > +}; Spotted C99 syntax of flexible array. Are we OK with all

[dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action items support

2018-04-05 Thread Declan Doherty
Introduces a new action type RTE_FLOW_ACTION_TYPE_METADATA which enables metadata extraction from a packet into a specified metadata container for consumption on further pipeline stages or for propagation to the host interface. As complementary function to the new metadata action type this patch a