Re: [dpdk-dev] [PATCH v2 3/4] ether: add more protocol support in flow API

2018-04-12 Thread Zhang, Qi Z
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Thursday, April 12, 2018 5:20 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Doherty, Declan ; Chandran, > Sugesh ; Glynn, Michael J > ; Liu, Yu Y ; Ananyev, > Konstantin ; Richardson, Bruce > > Subject:

Re: [dpdk-dev] [PATCH v2 3/4] ether: add more protocol support in flow API

2018-04-12 Thread Adrien Mazarguil
On Thu, Apr 12, 2018 at 05:12:08AM +, Zhang, Qi Z wrote: > Hi Adrien: > > Thank you so much for your careful review and helpful suggestions! > I agree with most of your comments, except couple question about > RTE_FLOW_ITEM_TYPE_TGT_ADDR and RTE_FLOW_ITEM_IPV6_EXT_HDR > Plea

Re: [dpdk-dev] [PATCH v2 3/4] ether: add more protocol support in flow API

2018-04-11 Thread Zhang, Qi Z
Hi Adrien: Thank you so much for your careful review and helpful suggestions! I agree with most of your comments, except couple question about RTE_FLOW_ITEM_TYPE_TGT_ADDR and RTE_FLOW_ITEM_IPV6_EXT_HDR Please see my comment inline. Thanks! Qi > -Original Message-

Re: [dpdk-dev] [PATCH v2 3/4] ether: add more protocol support in flow API

2018-04-11 Thread Adrien Mazarguil
On Sun, Apr 01, 2018 at 05:19:21PM -0400, Qi Zhang wrote: > Add new protocol header match support as below > > RTE_FLOW_ITEM_TYPE_ARP > - match IPv4 ARP header > RTE_FLOW_ITEM_TYPE_EXT_HDR_ANY > - match any IPv6 extension header While properly defined in the patch, "IPV6" is missing h

[dpdk-dev] [PATCH v2 3/4] ether: add more protocol support in flow API

2018-04-01 Thread Qi Zhang
Add new protocol header match support as below RTE_FLOW_ITEM_TYPE_ARP - match IPv4 ARP header RTE_FLOW_ITEM_TYPE_EXT_HDR_ANY - match any IPv6 extension header RTE_FLOW_ITEM_TYPE_ICMPV6 - match IPv6 ICMP header RTE_FLOW_ITEM_TYPE_ICMPV6_TGT_ADDR - match IPv6 ICMP Tar