Re: [dpdk-dev] [PATCH v2 3/3] testpmd: remove the dev event callback register

2018-07-09 Thread Jeff Guo
On 7/9/2018 4:16 PM, Andrew Rybchenko wrote: On 09.07.2018 09:56, Jeff Guo wrote: Since now we can use driver to management the eal event for hotplug, so no need to register dev event callback in app anymore. This patch remove the related code. I don't understand why handling on device leve

Re: [dpdk-dev] [PATCH v2 3/3] testpmd: remove the dev event callback register

2018-07-09 Thread Andrew Rybchenko
On 09.07.2018 09:56, Jeff Guo wrote: Since now we can use driver to management the eal event for hotplug, so no need to register dev event callback in app anymore. This patch remove the related code. I don't understand why handling on device level means removal of the application callback. May

Re: [dpdk-dev] [PATCH v2 3/3] testpmd: remove the dev event callback register

2018-07-09 Thread Lu, Wenzhuo
tho...@monjalon.net; mo...@mellanox.com; ma...@mellanox.com; Van > Haaren, Harry ; Zhang, Qi Z > ; He, Shaopeng ; > Iremonger, Bernard ; > arybche...@solarflare.com > Cc: jblu...@infradead.org; shreyansh.j...@nxp.com; dev@dpdk.org; Guo, > Jia ; Zhang, Helin > Subject: [dpd

[dpdk-dev] [PATCH v2 3/3] testpmd: remove the dev event callback register

2018-07-08 Thread Jeff Guo
Since now we can use driver to management the eal event for hotplug, so no need to register dev event callback in app anymore. This patch remove the related code. Signed-off-by: Jeff Guo --- v2->v1: no change. --- app/test-pmd/testpmd.c | 76 -- 1