Hi Vladimir,
> -Original Message-
> From: Medvedkin, Vladimir
> Sent: Wednesday, June 19, 2019 20:51
> To: Ruifeng Wang (Arm Technology China) ;
> bruce.richard...@intel.com
> Cc: dev@dpdk.org; Honnappa Nagarahalli
> ; Gavin Hu (Arm Technology China)
> ; nd
> Subject: Re: [PATCH v2 3/3]
Hi Wang,
1. It is better to explicitly use __rte_noinline with this function
because my gcc still inlines it even without the inline qualifier.
2. The same should be applied to _v20 functions.
3. Please try running the tests again and show the results.
4. Make this patch the first in a serie
Tests showed that the 'inline' keyword caused performance drop
on some x86 platforms after the memory ordering patches applied.
By removing the 'inline' keyword, the performance was recovered
as before on x86 and no impact to arm64 platforms.
Suggested-by: Medvedkin Vladimir
Signed-off-by: Ruifen
3 matches
Mail list logo
