Re: [dpdk-dev] [PATCH v2 3/3] drivers: align log names

2021-04-06 Thread Wang, Xiao W
Hi Thomas, I agree with the "ifcvf" name, as there might be more than one driver in a single driver dir. Thanks, Xiao > -Original Message- > From: Xu, Rosen > Sent: Tuesday, April 6, 2021 5:48 PM > To: Thomas Monjalon ; Wang, Xiao W > > Cc: dev@dpdk.org; Richardson, Bruce ; > Hemant A

Re: [dpdk-dev] [PATCH v2 3/3] drivers: align log names

2021-04-06 Thread Xu, Rosen
HI Thomas, I'm ok, if you replace pmd.afu.ipn3ke with pmd.net.ipn3ke. Thanks your reminder. > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 06, 2021 17:31 > To: Xu, Rosen ; Wang, Xiao W > > Cc: dev@dpdk.org; Richardson, Bruce ; > Hemant Agrawal ; Ajit Khaparde > ; Gr

Re: [dpdk-dev] [PATCH v2 3/3] drivers: align log names

2021-04-06 Thread Thomas Monjalon
Hi Rosen, You already gave your ack in previous version, no need to re-ack. Instead, please give your opinion and explanation as requested below. We want to replace pmd.afu.ipn3ke with pmd.net.ipn3ke. The use of AFU in the driver is not clear. Xiao, we need your opinion as well about ifcvf vs ifc

Re: [dpdk-dev] [PATCH v2 3/3] drivers: align log names

2021-04-05 Thread Min Hu (Connor)
Acked-by: Min Hu (Connor) 在 2021/4/5 18:03, Thomas Monjalon 写道: The log levels are configured by using the name of the logs. Some drivers are aligned to follow a common log name standard: pmd.class.driver[.sub] Some "common" drivers skip the "class" part: pmd.driver.sub Two dri

Re: [dpdk-dev] [PATCH v2 3/3] drivers: align log names

2021-04-05 Thread Xu, Rosen
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Monday, April 05, 2021 18:03 > To: dev@dpdk.org > Cc: Richardson, Bruce ; Xu, Rosen > ; Wang, Xiao W ; Hemant > Agrawal ; Ajit Khaparde > ; Griffin, John ; > Trahe, Fiona ; Jain, Deepak K > ; Raveendra Padasalagi > ; Vikas Gupta > ;

Re: [dpdk-dev] [PATCH v2 3/3] drivers: align log names

2021-04-05 Thread Wang, Xiao W
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Monday, April 5, 2021 6:03 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Xu, Rosen > ; Wang, Xiao W ; Hemant > Agrawal ; Ajit Khaparde > ; Griffin, John ; > Trahe, Fiona ; Jain, Deepak K > ; Raveendra Padasalagi > ; V

[dpdk-dev] [PATCH v2 3/3] drivers: align log names

2021-04-05 Thread Thomas Monjalon
The log levels are configured by using the name of the logs. Some drivers are aligned to follow a common log name standard: pmd.class.driver[.sub] Some "common" drivers skip the "class" part: pmd.driver.sub Two drivers have exceptions to be clarified: pmd.vdpa.ifcvf instead