Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-04-09 Thread Jerin Jacob
On Thu, Apr 9, 2020 at 5:16 PM Ferruh Yigit wrote: > > On 3/20/2020 6:13 AM, Jerin Jacob wrote: > > On Thu, Mar 19, 2020 at 7:21 PM Viacheslav Ovsiienko > > wrote: > >> > >> The execution time of rx/tx burst routine depends on the burst size. > >> It would be meaningful to research this dependenc

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-04-09 Thread Thomas Monjalon
09/04/2020 14:03, Ferruh Yigit: > On 3/19/2020 1:50 PM, Viacheslav Ovsiienko wrote: > > - pkt_burst_stats_display("RX", &fs->rx_burst_stats); > > - pkt_burst_stats_display("TX", &fs->tx_burst_stats); > > + pkt_burst_stats_display(false, &fs->rx_burst_stats); > > + pkt_burst_stats_display(tr

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-04-09 Thread Ferruh Yigit
On 3/19/2020 1:50 PM, Viacheslav Ovsiienko wrote: > The execution time of rx/tx burst routine depends on the burst size. > It would be meaningful to research this dependency, the patch > provides an extra profiling data per rx/tx burst size. > > Signed-off-by: Viacheslav Ovsiienko <...> > @@ -1

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-04-09 Thread Ferruh Yigit
On 3/20/2020 6:13 AM, Jerin Jacob wrote: > On Thu, Mar 19, 2020 at 7:21 PM Viacheslav Ovsiienko > wrote: >> >> The execution time of rx/tx burst routine depends on the burst size. >> It would be meaningful to research this dependency, the patch >> provides an extra profiling data per rx/tx burst s

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-04-02 Thread Thomas Monjalon
19/03/2020 14:50, Viacheslav Ovsiienko: > + printf(" CPU cycles/%u packet burst=%u (total cycles=" > +"%"PRIu64" / total %s bursts=%u)\n", You can make it simpler by removing some words: CPU cycles -> cycles packet burst -> burst

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-03-20 Thread Andrzej Ostruszka
Viacheslav, thanks for the patches. I'll comment here on the whole patch set. This patch set has many similar changes so I'll focus on the first (csumonly) and the comment will apply to all remaining - OK? On 3/19/20 2:50 PM, Viacheslav Ovsiienko wrote: > The execution time of rx/tx burst routin

Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-03-19 Thread Jerin Jacob
On Thu, Mar 19, 2020 at 7:21 PM Viacheslav Ovsiienko wrote: > > The execution time of rx/tx burst routine depends on the burst size. > It would be meaningful to research this dependency, the patch > provides an extra profiling data per rx/tx burst size. > > Signed-off-by: Viacheslav Ovsiienko >

[dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size

2020-03-19 Thread Viacheslav Ovsiienko
The execution time of rx/tx burst routine depends on the burst size. It would be meaningful to research this dependency, the patch provides an extra profiling data per rx/tx burst size. Signed-off-by: Viacheslav Ovsiienko --- app/test-pmd/csumonly.c | 11 +++ app/test-pmd/flowgen.c