Re: [dpdk-dev] [PATCH v2 2/5] ethdev: add capability to keep shared objects on restart

2021-10-17 Thread Ori Kam
Hi Dmitry. > -Original Message- > From: Dmitry Kozlyuk > Sent: Sunday, October 17, 2021 12:15 PM > Subject: RE: [PATCH v2 2/5] ethdev: add capability to keep shared objects on > restart > > > [...] > > > +By default it is unspecified if indirect actions persist after the > > device stop

Re: [dpdk-dev] [PATCH v2 2/5] ethdev: add capability to keep shared objects on restart

2021-10-17 Thread Ori Kam
Hi Dmitry > -Original Message- > From: Dmitry Kozlyuk > Sent: Friday, October 15, 2021 7:18 PM > To: dev@dpdk.org > Subject: [PATCH v2 2/5] ethdev: add capability to keep shared objects on > restart > > rte_flow_action_handle_create() did not mention what happens with an indirect > act

Re: [dpdk-dev] [PATCH v2 2/5] ethdev: add capability to keep shared objects on restart

2021-10-17 Thread Dmitry Kozlyuk
> [...] > > +By default it is unspecified if indirect actions persist after the > device stop. > > +If ``RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP`` is not advertised, then > > +indirect actions must be explicitly destroyed before stopping the > > +device if the application needs to ensure they are

[dpdk-dev] [PATCH v2 2/5] ethdev: add capability to keep shared objects on restart

2021-10-15 Thread Dmitry Kozlyuk
rte_flow_action_handle_create() did not mention what happens with an indirect action when a device is stopped, possibly reconfigured, and started again. It is natural for some indirect actions to be persistent, like counters and meters; keeping others just saves application time and complexity. How