Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-04-02 Thread Thomas Monjalon
03/04/2019 01:35, Ferruh Yigit: > On 4/1/2019 9:09 AM, Thomas Monjalon wrote: > > 01/04/2019 08:46, David Marchand: > >> On Mon, Apr 1, 2019 at 4:16 AM Thomas Monjalon wrote: > >> > >>> 19/03/2019 19:04, Ferruh Yigit: > On 3/19/2019 5:34 PM, Thomas Monjalon wrote: > >>> +uint16_t __rte_ex

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-04-02 Thread Ferruh Yigit
On 4/1/2019 9:09 AM, Thomas Monjalon wrote: > 01/04/2019 08:46, David Marchand: >> On Mon, Apr 1, 2019 at 4:16 AM Thomas Monjalon wrote: >> >>> 19/03/2019 19:04, Ferruh Yigit: On 3/19/2019 5:34 PM, Thomas Monjalon wrote: >>> +uint16_t __rte_experimental >> >> Do we need _rte_exper

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-04-01 Thread Thomas Monjalon
01/04/2019 08:46, David Marchand: > On Mon, Apr 1, 2019 at 4:16 AM Thomas Monjalon wrote: > > > 19/03/2019 19:04, Ferruh Yigit: > > > On 3/19/2019 5:34 PM, Thomas Monjalon wrote: > > > >>> +uint16_t __rte_experimental > > > >> > > > >> Do we need _rte_experimental on function definitions? I guess

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-03-31 Thread David Marchand
On Mon, Apr 1, 2019 at 4:16 AM Thomas Monjalon wrote: > 19/03/2019 19:04, Ferruh Yigit: > > On 3/19/2019 5:34 PM, Thomas Monjalon wrote: > > >>> +uint16_t __rte_experimental > > >> > > >> Do we need _rte_experimental on function definitions? I guess only in > .h file, > > >> function declaration

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-03-31 Thread Thomas Monjalon
19/03/2019 19:04, Ferruh Yigit: > On 3/19/2019 5:34 PM, Thomas Monjalon wrote: > >>> +uint16_t __rte_experimental > >> > >> Do we need _rte_experimental on function definitions? I guess only in .h > >> file, > >> function declaration is enough. > > > > Yes we need them both in .h and .c files. >

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-03-31 Thread Thomas Monjalon
27/02/2019 11:51, Thomas Monjalon: > 27/02/2019 11:07, Gaëtan Rivet: > > On Wed, Feb 20, 2019 at 11:10:49PM +0100, Thomas Monjalon wrote: > > > +uint16_t __rte_experimental > > > +rte_eth_find_next_of(uint16_t port_id, const struct rte_device *parent) > > > +{ > > > + while (port_id < RTE_MAX_ETHPO

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-03-19 Thread Ferruh Yigit
On 3/19/2019 5:34 PM, Thomas Monjalon wrote: >>> +uint16_t __rte_experimental >> Do we need _rte_experimental on function definitions? I guess only in .h >> file, >> function declaration is enough. > Yes we need them both in .h and .c files. > Why we need them in .c file? I think the compiler is

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-03-19 Thread Thomas Monjalon
19/03/2019 16:47, Ferruh Yigit: > On 2/20/2019 10:10 PM, Thomas Monjalon wrote: > > If multiple ports share the same hardware device (rte_device), > > they are siblings and can be found thanks to the new functions > > and loop macros. > > One iterator takes a port id as reference, > > while the oth

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-03-19 Thread Ferruh Yigit
On 2/20/2019 10:10 PM, Thomas Monjalon wrote: > If multiple ports share the same hardware device (rte_device), > they are siblings and can be found thanks to the new functions > and loop macros. > One iterator takes a port id as reference, > while the other one directly refers to the parent device.

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-02-27 Thread Thomas Monjalon
27/02/2019 11:07, Gaëtan Rivet: > Hi Thomas, > > On Wed, Feb 20, 2019 at 11:10:49PM +0100, Thomas Monjalon wrote: > > If multiple ports share the same hardware device (rte_device), > > they are siblings and can be found thanks to the new functions > > and loop macros. > > One iterator takes a port

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-02-27 Thread Gaëtan Rivet
Hi Thomas, On Wed, Feb 20, 2019 at 11:10:49PM +0100, Thomas Monjalon wrote: > If multiple ports share the same hardware device (rte_device), > they are siblings and can be found thanks to the new functions > and loop macros. > One iterator takes a port id as reference, > while the other one direct

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-02-24 Thread Andrew Rybchenko
On 2/21/19 1:10 AM, Thomas Monjalon wrote: If multiple ports share the same hardware device (rte_device), they are siblings and can be found thanks to the new functions and loop macros. One iterator takes a port id as reference, while the other one directly refers to the parent device. The owner

[dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators

2019-02-20 Thread Thomas Monjalon
If multiple ports share the same hardware device (rte_device), they are siblings and can be found thanks to the new functions and loop macros. One iterator takes a port id as reference, while the other one directly refers to the parent device. The ownership is not checked because siblings may have