Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP checksum definition

2018-10-03 Thread Iremonger, Bernard
erruh ; Andrew Rybchenko > ; Olivier Matz > Cc: dev@dpdk.org; shah...@mellanox.com; Jerin Jacob > > Subject: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP checksum > definition > > Introduced DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags and > PKT_TX_OUTER_TCP_CKS

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP checksum definition

2018-10-03 Thread Thomas Monjalon
03/10/2018 10:02, Ferruh Yigit: > On 10/3/2018 8:58 AM, Jerin Jacob wrote: > > From: Andrew Rybchenko > >> The question about mbuf and ethdev changes separation is applicable here as > >> well. I have no strong opinion, but I think it would be good to follow. > > > > I don't have strong opinion o

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP checksum definition

2018-10-03 Thread Ferruh Yigit
ic , >> Thomas Monjalon , Ferruh Yigit >> , Olivier Matz >> CC: dev@dpdk.org, shah...@mellanox.com >> Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP >> checksum definition >> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 >&

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP checksum definition

2018-10-03 Thread Jerin Jacob
k.org, shah...@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP > checksum definition > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 > Thunderbird/60.0 > > External Email > > On 10/2/18 10:24 PM, Jerin Jacob wr

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP checksum definition

2018-10-03 Thread Andrew Rybchenko
On 10/2/18 10:24 PM, Jerin Jacob wrote: Introduced DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags and PKT_TX_OUTER_TCP_CKSUM mbuf ol_flags to enable Tx outer UDP checksum offload. PKT_TX_OUTER_UDP_CKSUM, not TCP To use hardware Tx outer UDP checksum offload, the user needs to, - enable follow

[dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP checksum definition

2018-10-02 Thread Jerin Jacob
Introduced DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags and PKT_TX_OUTER_TCP_CKSUM mbuf ol_flags to enable Tx outer UDP checksum offload. To use hardware Tx outer UDP checksum offload, the user needs to, - enable following in mbuff: a) fill outer_l2_len and outer_l3_len in mbuf b) set the PKT_TX_