Re: [dpdk-dev] [PATCH v2 2/2] net/pcap: duplicate code consolidation

2018-06-21 Thread Ido Goshen
Although there's no functional need for them I considered keeping it for maintainability reasons: 1. Keep the call flow more aligned with pcap (file) that has separated open_rx_pcap()/open_tx_pcap() 2. If in future there'll rise a need for different functionality between rx and tx then it will b

Re: [dpdk-dev] [PATCH v2 2/2] net/pcap: duplicate code consolidation

2018-06-20 Thread Ferruh Yigit
On 6/20/2018 7:06 PM, Ido Goshen wrote: > Although there's no functional need for them I considered keeping it for > maintainability reasons: > 1. Keep the call flow more aligned with pcap (file) that has separated > open_rx_pcap()/open_tx_pcap() > 2. If in future there'll rise a need for differe

Re: [dpdk-dev] [PATCH v2 2/2] net/pcap: duplicate code consolidation

2018-06-20 Thread Ferruh Yigit
On 6/19/2018 3:37 PM, ido goshen wrote: > Signed-off-by: ido goshen <...> > /* > + * Opens a NIC for reading packets from it > + */ > +static inline int > +open_rx_iface(const char *key, const char *value, void *extra_args) > +{ > + return open_iface(key, value, extra_args); > +} > + > +/*

[dpdk-dev] [PATCH v2 2/2] net/pcap: duplicate code consolidation

2018-06-19 Thread ido goshen
Signed-off-by: ido goshen --- drivers/net/pcap/rte_eth_pcap.c | 77 + 1 file changed, 40 insertions(+), 37 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index b4f81ac..b21930b 100644 --- a/drivers/net/pcap/rte_