Re: [dpdk-dev] [PATCH v2 2/2] lpm: hide internal data

2020-10-23 Thread Medvedkin, Vladimir
Hello, On 23/10/2020 07:13, Ruifeng Wang wrote: -Original Message- From: David Marchand Sent: Thursday, October 22, 2020 11:14 PM To: Ruifeng Wang Cc: Bruce Richardson ; Vladimir Medvedkin ; dev ; Honnappa Nagarahalli ; nd ; Kevin Traynor ; tho...@monjalon.net Subject: Re: [PATCH v2

Re: [dpdk-dev] [PATCH v2 2/2] lpm: hide internal data

2020-10-22 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Thursday, October 22, 2020 11:14 PM > To: Ruifeng Wang > Cc: Bruce Richardson ; Vladimir Medvedkin > ; dev ; Honnappa > Nagarahalli ; nd ; Kevin > Traynor ; tho...@monjalon.net > Subject: Re: [PATCH v2 2/2] lpm: hide internal data > >

Re: [dpdk-dev] [PATCH v2 2/2] lpm: hide internal data

2020-10-22 Thread David Marchand
On Wed, Oct 21, 2020 at 5:02 AM Ruifeng Wang wrote: > diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c > index 51a0ae578..88d31df6d 100644 > --- a/lib/librte_lpm/rte_lpm.c > +++ b/lib/librte_lpm/rte_lpm.c > @@ -42,9 +42,17 @@ enum valid_flag { > > /** @internal LPM structure. */ >

Re: [dpdk-dev] [PATCH v2 2/2] lpm: hide internal data

2020-10-21 Thread Ruifeng Wang
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 21, 2020 3:59 PM > To: Ruifeng Wang > Cc: Bruce Richardson ; Vladimir Medvedkin > ; dev@dpdk.org; Honnappa Nagarahalli > ; nd ; David Marchand > ; Kevin Traynor > Subject: Re: [PATCH v2 2/2] lpm: hide internal data

Re: [dpdk-dev] [PATCH v2 2/2] lpm: hide internal data

2020-10-21 Thread Thomas Monjalon
21/10/2020 05:02, Ruifeng Wang: > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -602,6 +602,8 @@ ABI Changes > > * sched: Added new fields to ``struct rte_sched_subport_port_params``. > > +* lpm: Removed fields other than ``tbl24`` and ``tbl8`

[dpdk-dev] [PATCH v2 2/2] lpm: hide internal data

2020-10-20 Thread Ruifeng Wang
Fields except tbl24 and tbl8 in rte_lpm structure have no need to be exposed to the user. Hide the unneeded exposure of structure fields for better ABI maintainability. Suggested-by: David Marchand Signed-off-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Kevin Traynor Acked-by: