Re: [dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp

2023-07-03 Thread Stephen Hemminger
On Thu, 19 Aug 2021 12:34:46 -0700 Sowmini Varadhan wrote: > On (08/19/21 16:21), Iremonger, Bernard wrote: > > > > Looking closer at this patchset, I am not sure that a second ACL table is > > needed. > > The existing ACL table handles UDP, TCP and SCP, however it is not > > processing the TC

Re: [dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp

2021-08-19 Thread Sowmini Varadhan
On (08/19/21 16:21), Iremonger, Bernard wrote: > > Looking closer at this patchset, I am not sure that a second ACL table is > needed. > The existing ACL table handles UDP, TCP and SCP, however it is not processing > the TCP flags. > I think it just needs to be modified to process the TCP flags.

Re: [dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp

2021-08-19 Thread Iremonger, Bernard
Hi Sowmini, Looking closer at this patchset, I am not sure that a second ACL table is needed. The existing ACL table handles UDP, TCP and SCP, however it is not processing the TCP flags. I think it just needs to be modified to process the TCP flags. Could you take another look to see if the abov

Re: [dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp

2021-08-19 Thread Sowmini Varadhan
On (08/19/21 15:06), Iremonger, Bernard wrote: > > v2 updates: typo fixes for checkpatch, bernard.iremonger comments > > The above line should not be added to the commit message. > ~/dpdk/devtools/check-git-log.sh -1 > Wrong tag: > v2 fixes: typo fixes, get_tcp_flags returns -EINVAL > >

Re: [dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp

2021-08-19 Thread Iremonger, Bernard
Hi Sowmini, > -Original Message- > From: Sowmini Varadhan > Sent: Wednesday, August 18, 2021 4:01 PM > To: sowmin...@gmail.com; Iremonger, Bernard > ; dev@dpdk.org; > sovar...@linux.microsoft.com > Cc: tho...@monjalon.net > Subject: [PATCH v2 2/2] examples/flow_classify: add an ACL table

[dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp

2021-08-18 Thread Sowmini Varadhan
v2 updates: typo fixes for checkpatch, bernard.iremonger comments The struct rte_flow_classifier can have up to RTE_FLOW_CLASSIFY_TABLE_MAX (32) classifier tables, but the existing flow_classify examples only adds a single table for the L4 5-tuple. When dealing with tcp flows, we frequently want