Re: [dpdk-dev] [PATCH v2 2/2] Fix variable assignment.

2019-02-28 Thread Thomas Monjalon
Hi, Few minor comments, The title should start with "devtools:" and not end with dot. One suggestion: devtools: fix result of svg include check 14/02/2019 20:35, Michael Santana: > Fix trivial bug. In sh shell, 'foo = 1' is not the same as > 'foo=1'. Using 'foo = 1' makes the shell attem

[dpdk-dev] [PATCH v2 2/2] Fix variable assignment.

2019-02-14 Thread Michael Santana
Fix trivial bug. In sh shell, 'foo = 1' is not the same as 'foo=1'. Using 'foo = 1' makes the shell attempt to interpret foo as a command, rather than a simple variable assignment. Signed-off-by: Michael Santana Fixes: dafc04c15174 ("hash: fix out-of-bound write while freeing key slot") --- v2: