Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-20 Thread Ye Xiaolong
Thanks for your comments. On 03/20, David Marchand wrote: >On Tue, Mar 19, 2019 at 8:17 AM Xiaolong Ye wrote: > >> diff --git a/doc/guides/nics/features/af_xdp.ini >> b/doc/guides/nics/features/af_xdp.ini >> new file mode 100644 >> index 0..7b8fcce00 >> --- /dev/null >> +++ b/doc/guides/n

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-20 Thread David Marchand
On Tue, Mar 19, 2019 at 8:17 AM Xiaolong Ye wrote: > diff --git a/doc/guides/nics/features/af_xdp.ini > b/doc/guides/nics/features/af_xdp.ini > new file mode 100644 > index 0..7b8fcce00 > --- /dev/null > +++ b/doc/guides/nics/features/af_xdp.ini > @@ -0,0 +1,11 @@ > +; > +; Supported feat

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Ye Xiaolong
Hi, Stephen On 03/19, Stephen Hemminger wrote: >Lots of little review comments. This is what I saw in 30 minutes. >Expect more. Thanks for taking time to review my patch. They are all valuable inputs. > > >On Tue, 19 Mar 2019 15:12:51 +0800 >Xiaolong Ye wrote: > >> +nb_pkts = nb_pkts < ETH_

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Ye Xiaolong
On 03/19, Bruce Richardson wrote: >> This is bad. Configure your editor to always put newline at end of file. >> In .emacs >> >>(setq require-final-newline t) >> >Or use Vim which needs no extra configuration to do this. :-) I used to be a Vimer, just switch to emacs recently. :-) >

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Ye Xiaolong
On 03/19, Stephen Hemminger wrote: >> \ No newline at end of file > > >This is bad. Configure your editor to always put newline at end of file. >In .emacs > > (setq require-final-newline t) > I wasn't aware of it before, thanks for the info, will configure it for my emacs. Thanks, Xiaolong

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Bruce Richardson
On Tue, Mar 19, 2019 at 09:16:27AM -0700, Stephen Hemminger wrote: > On Tue, 19 Mar 2019 15:12:51 +0800 > Xiaolong Ye wrote: > > > Add a new PMD driver for AF_XDP which is a proposed faster version of > > AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] > > [2]. > > > >

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Stephen Hemminger
On Tue, 19 Mar 2019 15:12:51 +0800 Xiaolong Ye wrote: > Add a new PMD driver for AF_XDP which is a proposed faster version of > AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] > [2]. > > This is the vanilla version PMD which just uses a raw buffer registered as > the um

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Stephen Hemminger
Lots of little review comments. This is what I saw in 30 minutes. Expect more. On Tue, 19 Mar 2019 15:12:51 +0800 Xiaolong Ye wrote: > + nb_pkts = nb_pkts < ETH_AF_XDP_RX_BATCH_SIZE ? > + nb_pkts : ETH_AF_XDP_RX_BATCH_SIZE; Maybe use RTE_MIN() ? > + mbuf = rte_pktm

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Ye Xiaolong
Hi, Mattias Thanks for your comments. On 03/19, Mattias Rönnblom wrote: >On 2019-03-19 08:12, Xiaolong Ye wrote: >> Add a new PMD driver for AF_XDP which is a proposed faster version of >> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] >> [2]. >> >> This is the vanilla

Re: [dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Mattias Rönnblom
On 2019-03-19 08:12, Xiaolong Ye wrote: Add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] [2]. This is the vanilla version PMD which just uses a raw buffer registered as the umem. [1] https://fosdem.or

[dpdk-dev] [PATCH v2 1/6] net/af_xdp: introduce AF XDP PMD driver

2019-03-19 Thread Xiaolong Ye
Add a new PMD driver for AF_XDP which is a proposed faster version of AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] [2]. This is the vanilla version PMD which just uses a raw buffer registered as the umem. [1] https://fosdem.org/2018/schedule/event/af_xdp/ [2] https://