Re: [dpdk-dev] [PATCH v2 1/5] net/virtio: prevent simple Tx path selection by default

2018-06-07 Thread Tiwei Bie
On Thu, Jun 07, 2018 at 09:40:35AM +0200, Maxime Coquelin wrote: > On 06/07/2018 07:43 AM, Tiwei Bie wrote: > > On Wed, Jun 06, 2018 at 02:31:24PM +0200, Maxime Coquelin wrote: > > [...] > > > + > > > +static int > > > +virtio_dev_args(struct rte_eth_dev *dev) > > > +{ > > > + struct rte_kvargs *kv

Re: [dpdk-dev] [PATCH v2 1/5] net/virtio: prevent simple Tx path selection by default

2018-06-07 Thread Maxime Coquelin
On 06/07/2018 07:43 AM, Tiwei Bie wrote: On Wed, Jun 06, 2018 at 02:31:24PM +0200, Maxime Coquelin wrote: [...] + +static int +virtio_dev_args(struct rte_eth_dev *dev) +{ + struct rte_kvargs *kvlist; + struct rte_devargs *devargs; + const char *valid_args[] = { +

Re: [dpdk-dev] [PATCH v2 1/5] net/virtio: prevent simple Tx path selection by default

2018-06-06 Thread Tiwei Bie
On Wed, Jun 06, 2018 at 02:31:24PM +0200, Maxime Coquelin wrote: [...] > + > +static int > +virtio_dev_args(struct rte_eth_dev *dev) > +{ > + struct rte_kvargs *kvlist; > + struct rte_devargs *devargs; > + const char *valid_args[] = { > + VIRTIO_SIMPLE_TX_SUPPORT, > +

[dpdk-dev] [PATCH v2 1/5] net/virtio: prevent simple Tx path selection by default

2018-06-06 Thread Maxime Coquelin
Simple Tx path is not compliant with the Virtio specification, as it assumes the device will use the descriptors in order. VIRTIO_F_IN_ORDER feature has been introduced recently, but the simple Tx path is not compliant with it as VIRTIO_F_IN_ORDER requires that chained descriptors are used sequent