Re: [dpdk-dev] [PATCH v2 1/5] hash: add new toeplitz hash implementation

2021-10-19 Thread Medvedkin, Vladimir
Hi Stephen, On 19/10/2021 03:15, Stephen Hemminger wrote: On Mon, 18 Oct 2021 10:40:00 + "Ananyev, Konstantin" wrote: On Fri, 15 Oct 2021 10:30:02 +0100 Vladimir Medvedkin wrote: + m[i * 8 + j] = (rss_key[i] << j)| + (uint8_t)((uin

Re: [dpdk-dev] [PATCH v2 1/5] hash: add new toeplitz hash implementation

2021-10-18 Thread Stephen Hemminger
On Mon, 18 Oct 2021 10:40:00 + "Ananyev, Konstantin" wrote: > > On Fri, 15 Oct 2021 10:30:02 +0100 > > Vladimir Medvedkin wrote: > > > > > + m[i * 8 + j] = (rss_key[i] << j)| > > > + (uint8_t)((uint16_t)(rss_key[i + 1]) >> > > > +

Re: [dpdk-dev] [PATCH v2 1/5] hash: add new toeplitz hash implementation

2021-10-18 Thread Medvedkin, Vladimir
Hi Stephen, Thanks for reviewing On 15/10/2021 18:58, Stephen Hemminger wrote: On Fri, 15 Oct 2021 10:30:02 +0100 Vladimir Medvedkin wrote: + m[i * 8 + j] = (rss_key[i] << j)| + (uint8_t)((uint16_t)(rss_key[i + 1]) >> +

Re: [dpdk-dev] [PATCH v2 1/5] hash: add new toeplitz hash implementation

2021-10-18 Thread Ananyev, Konstantin
> On Fri, 15 Oct 2021 10:30:02 +0100 > Vladimir Medvedkin wrote: > > > + m[i * 8 + j] = (rss_key[i] << j)| > > + (uint8_t)((uint16_t)(rss_key[i + 1]) >> > > + (8 - j)); > > + } > > This ends up being harder than ne

Re: [dpdk-dev] [PATCH v2 1/5] hash: add new toeplitz hash implementation

2021-10-15 Thread Stephen Hemminger
On Fri, 15 Oct 2021 10:30:02 +0100 Vladimir Medvedkin wrote: > + m[i * 8 + j] = (rss_key[i] << j)| > + (uint8_t)((uint16_t)(rss_key[i + 1]) >> > + (8 - j)); > + } This ends up being harder than necessary to r

[dpdk-dev] [PATCH v2 1/5] hash: add new toeplitz hash implementation

2021-10-15 Thread Vladimir Medvedkin
This patch add a new Toeplitz hash implementation using Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin --- doc/api/doxy-api-index.md | 1 + lib/hash/meson.build | 1 + lib/hash/rte_thash.c | 28 ++ lib/hash/rte_thash.h | 24 + lib/hash/rte_t