Re: [dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data

2019-03-05 Thread Thomas Monjalon
05/03/2019 18:40, Gaëtan Rivet: > On Tue, Mar 05, 2019 at 05:43:26PM +0100, Gaëtan Rivet wrote: > > I have had a little trouble reading the patches. I think the 3 first > > should be squashed into a single one, it would be more coherent. > > > > I think I have seen a few points where doing so woul

Re: [dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data

2019-03-05 Thread Gaëtan Rivet
On Tue, Mar 05, 2019 at 05:43:26PM +0100, Gaëtan Rivet wrote: > Hello Raslan, > > Sorry for the delay. > > I have had a little trouble reading the patches. I think the 3 first > should be squashed into a single one, it would be more coherent. > > I think I have seen a few points where doing so w

Re: [dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data

2019-03-05 Thread Gaëtan Rivet
Hello Raslan, Sorry for the delay. I have had a little trouble reading the patches. I think the 3 first should be squashed into a single one, it would be more coherent. I think I have seen a few points where doing so would have prevented some unnecessary changes for example, simplifying the seri

[dpdk-dev] [PATCH v2 1/4] net/failsafe: replace local device with shared data

2019-03-05 Thread Raslan Darawsheh
In multiprocess context, the private structure is shared between processes. The back reference from private to generic data was using a pointer to a per process eth_dev. It's now changed to a reference of the shared data. Signed-off-by: Raslan Darawsheh Signed-off-by: Thomas Monjalon --- driver