Re: [dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause

2018-10-26 Thread Bruce Richardson
On Fri, Oct 26, 2018 at 03:04:12AM +0100, Wang, Yipeng1 wrote: > >-Original Message- > >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > >> --- > >> lib/librte_hash/rte_cuckoo_hash.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/lib

Re: [dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause

2018-10-25 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >> --- >> lib/librte_hash/rte_cuckoo_hash.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lib/librte_hash/rte_cuckoo_hash.c >> b/lib/librte_hash/rte_cuckoo_hash.c >> inde

Re: [dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause

2018-10-25 Thread Honnappa Nagarahalli
> > There is a rte_pause in hash table reset function. > Since the loop is not a polling loop on shared data structure, the rte_pause > is not needed. > > Fixes: b26473ff8f4a ("hash: add reset function") > Cc: sta...@dpdk.org > > Signed-off-by: Yipeng Wang > --- > lib/librte_hash/rte_cuckoo_ha

Re: [dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause

2018-10-25 Thread Bruce Richardson
On Thu, Oct 25, 2018 at 08:31:16AM +0200, Mattias Rönnblom wrote: > On 2018-10-24 20:09, Yipeng Wang wrote: > > There is a rte_pause in hash table reset function. > > Since the loop is not a polling loop on shared > > data structure, the rte_pause is not needed. > > > > I'm guessing the include

Re: [dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause

2018-10-24 Thread Mattias Rönnblom
On 2018-10-24 20:09, Yipeng Wang wrote: There is a rte_pause in hash table reset function. Since the loop is not a polling loop on shared data structure, the rte_pause is not needed. I'm guessing the include is longer needed.

[dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause

2018-10-24 Thread Yipeng Wang
There is a rte_pause in hash table reset function. Since the loop is not a polling loop on shared data structure, the rte_pause is not needed. Fixes: b26473ff8f4a ("hash: add reset function") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang --- lib/librte_hash/rte_cuckoo_hash.c | 4 ++-- 1 file c