Re: [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals

2018-10-28 Thread Thomas Monjalon
05/10/2018 17:55, Andrew Rybchenko: > On 10/5/18 7:26 PM, Ferruh Yigit wrote: > > --- a/drivers/net/sfc/sfc_rx.c > > +++ b/drivers/net/sfc/sfc_rx.c > > -struct sfc_rss_hf_rte_to_efx sfc_rss_hf_map[] = { > > +static struct sfc_rss_hf_rte_to_efx sfc_rss_hf_map[] = { > > I'd prefer "static const" in

Re: [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals

2018-10-08 Thread Shreyansh Jain
On Friday 05 October 2018 09:56 PM, Ferruh Yigit wrote: Some global variables can indeed be static, add static keyword to them. Signed-off-by: Ferruh Yigit --- Series is based on next-net tree --- [...] drivers/bus/dpaa/base/fman/netcfg_layer.c | 2 +- drivers/bus/dpaa/dpaa_bus

Re: [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals

2018-10-07 Thread Jerin Jacob
-Original Message- > Date: Fri, 5 Oct 2018 17:26:08 +0100 > From: Ferruh Yigit > To: Reshma Pattan , Hemant Agrawal > , Shreyansh Jain , Ashish > Gupta , Fiona Trahe , > Pablo de Lara , Akhil Goyal > , Declan Doherty , Fan > Zhang , Rahul Lakkireddy > , Gaetan Rivet , Qi > Zhang , X

Re: [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals

2018-10-05 Thread Andrew Rybchenko
On 10/5/18 7:26 PM, Ferruh Yigit wrote: Some global variables can indeed be static, add static keyword to them. Signed-off-by: Ferruh Yigit --- <...> diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c index 000cd0b20..e71ddd001 100644 --- a/drivers/net/sfc/sfc_rx.c +++ b/driver

[dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals

2018-10-05 Thread Ferruh Yigit
Some global variables can indeed be static, add static keyword to them. Signed-off-by: Ferruh Yigit --- Series is based on next-net tree --- app/pdump/main.c| 6 +++--- drivers/bus/dpaa/base/fman/netcfg_layer.c | 2 +- drivers/bus/dpaa/dpaa_bus.c