[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Yuanhan Liu
On Mon, Jul 04, 2016 at 06:20:42PM +0530, Jerin Jacob wrote: > > > The former case will have issue as "hw" been used in "if" with > > > vtpci_with_feature. > > > > Oh, my bad. I overlooked it. Sorry for that! > > > > > OR > > > > > > if you meant just floating "struct virtio_hw *hw" without >

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Yuanhan Liu
On Mon, Jul 04, 2016 at 05:45:57PM +0530, Jerin Jacob wrote: > On Mon, Jul 04, 2016 at 07:02:25PM +0800, Yuanhan Liu wrote: > > On Mon, Jul 04, 2016 at 02:37:55PM +0530, Jerin Jacob wrote: > > > On Mon, Jul 04, 2016 at 04:42:32PM +0800, Yuanhan Liu wrote: > > > > On Mon, Jul 04, 2016 at 02:06:27PM

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Yuanhan Liu
On Mon, Jul 04, 2016 at 02:37:55PM +0530, Jerin Jacob wrote: > On Mon, Jul 04, 2016 at 04:42:32PM +0800, Yuanhan Liu wrote: > > On Mon, Jul 04, 2016 at 02:06:27PM +0530, Jerin Jacob wrote: > > > On Mon, Jul 04, 2016 at 03:36:48PM +0800, Yuanhan Liu wrote: > > > > On Fri, Jul 01, 2016 at 04:46:36PM

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Jerin Jacob
On Mon, Jul 04, 2016 at 08:26:30PM +0800, Yuanhan Liu wrote: > On Mon, Jul 04, 2016 at 05:45:57PM +0530, Jerin Jacob wrote: > > On Mon, Jul 04, 2016 at 07:02:25PM +0800, Yuanhan Liu wrote: > > > On Mon, Jul 04, 2016 at 02:37:55PM +0530, Jerin Jacob wrote: > > > > On Mon, Jul 04, 2016 at 04:42:32PM

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Jerin Jacob
On Mon, Jul 04, 2016 at 07:02:25PM +0800, Yuanhan Liu wrote: > On Mon, Jul 04, 2016 at 02:37:55PM +0530, Jerin Jacob wrote: > > On Mon, Jul 04, 2016 at 04:42:32PM +0800, Yuanhan Liu wrote: > > > On Mon, Jul 04, 2016 at 02:06:27PM +0530, Jerin Jacob wrote: > > > > On Mon, Jul 04, 2016 at 03:36:48PM

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Yuanhan Liu
On Mon, Jul 04, 2016 at 02:06:27PM +0530, Jerin Jacob wrote: > On Mon, Jul 04, 2016 at 03:36:48PM +0800, Yuanhan Liu wrote: > > On Fri, Jul 01, 2016 at 04:46:36PM +0530, Jerin Jacob wrote: > > > @@ -494,9 +486,6 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, > > > { > > > uint8_t vtpci_qu

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Yuanhan Liu
On Fri, Jul 01, 2016 at 04:46:36PM +0530, Jerin Jacob wrote: > @@ -494,9 +486,6 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, > { > uint8_t vtpci_queue_idx = 2 * queue_idx + VTNET_SQ_TQ_QUEUE_IDX; > > -#ifdef RTE_MACHINE_CPUFLAG_SSSE3 > - struct virtio_hw *hw = dev->data->dev_p

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Jerin Jacob
On Mon, Jul 04, 2016 at 04:42:32PM +0800, Yuanhan Liu wrote: > On Mon, Jul 04, 2016 at 02:06:27PM +0530, Jerin Jacob wrote: > > On Mon, Jul 04, 2016 at 03:36:48PM +0800, Yuanhan Liu wrote: > > > On Fri, Jul 01, 2016 at 04:46:36PM +0530, Jerin Jacob wrote: > > > > @@ -494,9 +486,6 @@ virtio_dev_tx_q

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-04 Thread Jerin Jacob
On Mon, Jul 04, 2016 at 03:36:48PM +0800, Yuanhan Liu wrote: > On Fri, Jul 01, 2016 at 04:46:36PM +0530, Jerin Jacob wrote: > > @@ -494,9 +486,6 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, > > { > > uint8_t vtpci_queue_idx = 2 * queue_idx + VTNET_SQ_TQ_QUEUE_IDX; > > > > -#ifdef RT

[dpdk-dev] [PATCH v2 1/3] virtio: conditional compilation cleanup

2016-07-01 Thread Jerin Jacob
Removed unnecessary compile time dependency on "use_simple_rxtx". Signed-off-by: Jerin Jacob --- drivers/net/virtio/Makefile | 3 --- drivers/net/virtio/virtio_pci.h | 1 + drivers/net/virtio/virtio_rxtx.c| 28 +--- drivers/net/virtio/virtio_