Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-23 Thread Van Haaren, Harry
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, July 22, 2020 7:50 PM > To: Van Haaren, Harry ; David Marchand > > Cc: dev@dpdk.org; igor.roma...@oktetlabs.ru; Yigit, Ferruh > ; nd ; acon...@redhat.com; > l.wojciec...@partner.samsung.com; Phil Yang ; > Honnappa Nagara

Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-22 Thread Honnappa Nagarahalli
+ Gage (as I referring to his commit below) > > > > > > +/** > > > > > + * Reports if a service lcore is currently running. > > > > > + * @retval 0 Service thread is not active, and has been returned to > EAL. > > > > > + * @retval 1 Service thread is in the service core polling loop. > > > > >

Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-22 Thread Van Haaren, Harry
> -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, July 21, 2020 9:24 PM > To: David Marchand > Cc: Van Haaren, Harry ; dev@dpdk.org; > igor.roma...@oktetlabs.ru; Yigit, Ferruh ; nd > ; acon...@redhat.com; l.wojciec...@partner.samsung.com; Phil > Yang ; Honnappa Nagarahall

Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-21 Thread Honnappa Nagarahalli
> Subject: Re: [PATCH v2 1/2] service: add API to retrieve service core active > > On Tue, Jul 21, 2020 at 9:43 PM Honnappa Nagarahalli > wrote: > > > @@ -457,6 +458,8 @@ service_runner_func(void *arg) > > > const int lcore = rte_lcore_id(); > > > struct core_state *cs = &lcore_states

Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-21 Thread David Marchand
On Tue, Jul 21, 2020 at 9:43 PM Honnappa Nagarahalli wrote: > > @@ -457,6 +458,8 @@ service_runner_func(void *arg) > > const int lcore = rte_lcore_id(); > > struct core_state *cs = &lcore_states[lcore]; > > > > + __atomic_store_n(&cs->thread_active, 1, __ATOMIC_RELAXED); > Essentia

Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-21 Thread Honnappa Nagarahalli
> Subject: [PATCH v2 1/2] service: add API to retrieve service core active > > This commit adds a new experimental API which allows the user to retrieve > the active state of an lcore. Knowing when the service lcore is completed its > polling loop can be useful to applications to avoid race cond

Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-21 Thread Phil Yang
dhat.com; > l.wojciec...@partner.samsung.com; Harry van Haaren > > Subject: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core > active > > This commit adds a new experimental API which allows the user > to retrieve the active state of an lcore. Knowing when the service > lcor

Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-20 Thread Lukasz Wojciechowski
W dniu 20.07.2020 o 16:38, Harry van Haaren pisze: > This commit adds a new experimental API which allows the user > to retrieve the active state of an lcore. Knowing when the service > lcore is completed its polling loop can be useful to applications > to avoid race conditions when e.g. finalizi

[dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-20 Thread Harry van Haaren
This commit adds a new experimental API which allows the user to retrieve the active state of an lcore. Knowing when the service lcore is completed its polling loop can be useful to applications to avoid race conditions when e.g. finalizing statistics. The service thread itself now has a variable