Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-15 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, March 15, 2017 8:16 PM > To: Dumitrescu, Cristian > Cc: De Lara Guarch, Pablo ; Singh, > Jasvinder ; dev@dpdk.org; Doherty, Declan > > Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-15 Thread Thomas Monjalon
2017-03-15 19:03, Dumitrescu, Cristian: > ... > > > > > > > I think it should be in librte_hash. > > > > > > > > > > > > Please check lib/librte_hash/rte_hash_crc.h > > > > > > > > > > Is it good to include payload crc calculation in hash library as I > > > > > see all > > hash > > > > related f

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-15 Thread Dumitrescu, Cristian
> -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, March 15, 2017 7:04 PM > To: 'Thomas Monjalon' ; De Lara Guarch, > Pablo > Cc: Singh, Jasvinder ; dev@dpdk.org; Doherty, > Declan > Subject: RE: [dpdk-dev] [PATCH v2 1/2] librte_ne

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-15 Thread Dumitrescu, Cristian
... > > > > > I think it should be in librte_hash. > > > > > > > > > > Please check lib/librte_hash/rte_hash_crc.h > > > > > > > > Is it good to include payload crc calculation in hash library as I see > > > > all > hash > > > related functionality there? > > > > > > I think yes. Pablo? > > > >

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-15 Thread Thomas Monjalon
2017-03-08 11:08, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2017-03-02 13:03, Singh, Jasvinder: > > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > > > 2017-02-28 12:08, Jasvinder Singh: > > > > > lib/librte_net/rte_net_crc.c | 664

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-08 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Monday, March 06, 2017 3:28 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Doherty, Declan; De Lara Guarch, Pablo > Subject: Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-06 Thread Thomas Monjalon
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute > > APIs > > > > 2017-02-28 12:08, Jasvinder Singh: > > > lib/librte_net/rte_net_crc.c | 664 > > + > > > lib/librte_net/rte_net_crc.h

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-02 Thread Singh, Jasvinder
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, March 1, 2017 6:46 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and comput

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-03-01 Thread Thomas Monjalon
2017-02-28 12:08, Jasvinder Singh: > lib/librte_net/rte_net_crc.c | 664 > + > lib/librte_net/rte_net_crc.h | 101 ++ I think it should be in librte_hash. Please check lib/librte_hash/rte_hash_crc.h

Re: [dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-02-28 Thread Jerin Jacob
On Tue, Feb 28, 2017 at 12:08:20PM +, Jasvinder Singh wrote: > APIs for initialising and computing the crc (16-bit and 32-bit CRCs) > are added. For CRCs calculation, scalar as well as x86 intrinsic(sse4.2) > versions are implemented. > > The scalar version is based on generic Look-Up Table(LU

[dpdk-dev] [PATCH v2 1/2] librte_net: add crc init and compute APIs

2017-02-28 Thread Jasvinder Singh
APIs for initialising and computing the crc (16-bit and 32-bit CRCs) are added. For CRCs calculation, scalar as well as x86 intrinsic(sse4.2) versions are implemented. The scalar version is based on generic Look-Up Table(LUT) algorithm, while x86 intrinsic version uses carry-less multiplication fo