Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-20 Thread Thomas Monjalon
20/03/2021 08:54, Andrew Rybchenko: > On 3/19/21 9:12 PM, Thomas Monjalon wrote: > > 15/03/2021 10:15, Thomas Monjalon: > >> 15/03/2021 10:08, Andrew Rybchenko: > >>> On 3/15/21 11:55 AM, Thomas Monjalon wrote: > 15/03/2021 09:43, Andrew Rybchenko: > > On 3/15/21 10:54 AM, Thomas Monjalon

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-20 Thread Andrew Rybchenko
On 3/19/21 9:12 PM, Thomas Monjalon wrote: 15/03/2021 10:15, Thomas Monjalon: 15/03/2021 10:08, Andrew Rybchenko: On 3/15/21 11:55 AM, Thomas Monjalon wrote: 15/03/2021 09:43, Andrew Rybchenko: On 3/15/21 10:54 AM, Thomas Monjalon wrote: 15/03/2021 08:18, Andrew Rybchenko: On 3/12/21 8:46 P

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-19 Thread Thomas Monjalon
15/03/2021 10:15, Thomas Monjalon: > 15/03/2021 10:08, Andrew Rybchenko: > > On 3/15/21 11:55 AM, Thomas Monjalon wrote: > > > 15/03/2021 09:43, Andrew Rybchenko: > > >> On 3/15/21 10:54 AM, Thomas Monjalon wrote: > > >>> 15/03/2021 08:18, Andrew Rybchenko: > > On 3/12/21 8:46 PM, Thomas Monja

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-15 Thread Thomas Monjalon
15/03/2021 10:08, Andrew Rybchenko: > On 3/15/21 11:55 AM, Thomas Monjalon wrote: > > 15/03/2021 09:43, Andrew Rybchenko: > >> On 3/15/21 10:54 AM, Thomas Monjalon wrote: > >>> 15/03/2021 08:18, Andrew Rybchenko: > On 3/12/21 8:46 PM, Thomas Monjalon wrote: > > --- a/lib/librte_ethdev/rte_

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-15 Thread Andrew Rybchenko
On 3/15/21 11:55 AM, Thomas Monjalon wrote: > 15/03/2021 09:43, Andrew Rybchenko: >> On 3/15/21 10:54 AM, Thomas Monjalon wrote: >>> 15/03/2021 08:18, Andrew Rybchenko: On 3/12/21 8:46 PM, Thomas Monjalon wrote: > --- a/lib/librte_ethdev/rte_flow.c > +++ b/lib/librte_ethdev/rte_flow.c

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-15 Thread Thomas Monjalon
15/03/2021 09:43, Andrew Rybchenko: > On 3/15/21 10:54 AM, Thomas Monjalon wrote: > > 15/03/2021 08:18, Andrew Rybchenko: > >> On 3/12/21 8:46 PM, Thomas Monjalon wrote: > >>> --- a/lib/librte_ethdev/rte_flow.c > >>> +++ b/lib/librte_ethdev/rte_flow.c > >>> @@ -255,18 +255,19 @@ rte_flow_ops_get(ui

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-15 Thread Andrew Rybchenko
On 3/15/21 10:54 AM, Thomas Monjalon wrote: > 15/03/2021 08:18, Andrew Rybchenko: >> On 3/12/21 8:46 PM, Thomas Monjalon wrote: >>> --- a/lib/librte_ethdev/rte_flow.c >>> +++ b/lib/librte_ethdev/rte_flow.c >>> @@ -255,18 +255,19 @@ rte_flow_ops_get(uint16_t port_id, struct >>> rte_flow_error *erro

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-15 Thread Thomas Monjalon
15/03/2021 08:18, Andrew Rybchenko: > On 3/12/21 8:46 PM, Thomas Monjalon wrote: > > --- a/lib/librte_ethdev/rte_flow.c > > +++ b/lib/librte_ethdev/rte_flow.c > > @@ -255,18 +255,19 @@ rte_flow_ops_get(uint16_t port_id, struct > > rte_flow_error *error) > > > > if (unlikely(!rte_eth_dev_is_v

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-15 Thread Hemant Agrawal
For dpaa2 Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-15 Thread Andrew Rybchenko
On 3/12/21 8:46 PM, Thomas Monjalon wrote: > Since rte_flow is the only API for filtering operations, > the legacy driver interface filter_ctrl was too much complicated > for the simple task of getting the struct rte_flow_ops. > > The filter type RTE_ETH_FILTER_GENERIC and > the filter operarion R

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-14 Thread Xu, Rosen
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Saturday, March 13, 2021 1:47 > To: dev@dpdk.org > Cc: Ori Kam ; Ajit Khaparde > ; Somnath Kotur > ; Chas Williams ; Min Hu > (Connor) ; Rahul Lakkireddy > ; Hemant Agrawal > ; Sachin Saxena ; > Guo, Jia ; Wang, Haiyue ; > Daley, Jo

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-12 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Saturday, March 13, 2021 01:47 > To: dev@dpdk.org > Cc: Ori Kam ; Ajit Khaparde ; > Somnath Kotur > ; Chas Williams ; Min Hu (Connor) > ; > Rahul Lakkireddy ; Hemant Agrawal > ; Sachin > Saxena ; Guo, Jia ; Wang, > Haiyue ; > Daley,

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-12 Thread Ajit Khaparde
On Fri, Mar 12, 2021 at 9:47 AM Thomas Monjalon wrote: > > Since rte_flow is the only API for filtering operations, > the legacy driver interface filter_ctrl was too much complicated > for the simple task of getting the struct rte_flow_ops. > > The filter type RTE_ETH_FILTER_GENERIC and > the filt

[dpdk-dev] [PATCH v2 1/2] ethdev: replace callback getting filter operations

2021-03-12 Thread Thomas Monjalon
Since rte_flow is the only API for filtering operations, the legacy driver interface filter_ctrl was too much complicated for the simple task of getting the struct rte_flow_ops. The filter type RTE_ETH_FILTER_GENERIC and the filter operarion RTE_ETH_FILTER_GET are removed. The new driver callback