23/10/2018 10:48, Joseph, Anoob:
> From: Thomas Monjalon
> > 22/10/2018 05:49, Joseph, Anoob:
> > > Hi Fiona,
> > >
> > > I do agree that your solution seems to be a neat way for organizing
> > capabilities. But Akhil & Thomas were against that idea and we had to come
> > up
> > with one array wi
gt; ; Dwivedi, Ankur
> ; Dabilpuram, Nithin
> ; Jayaraman, Ragothaman
> ; Srinivasan, Srisivasubramanian
> ; Tejasree, Kondoj
>
> Subject: Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric
> capabilities
>
> External Email
>
> 22/10/2018 05:49, Joseph, An
22/10/2018 05:49, Joseph, Anoob:
> Hi Fiona,
>
> I do agree that your solution seems to be a neat way for organizing
> capabilities. But Akhil & Thomas were against that idea and we had to come up
> with one array with all capabilities. This would not scale well when we start
> supporting devic
lo ; Murthy, Nidadavolu
> > ; Jacob, Jerin
> > ; Athreya, Narayana Prasad
> > ; Dwivedi, Ankur
> > ; Dabilpuram, Nithin
> > ; Jayaraman, Ragothaman
> > ; Srinivasan, Srisivasubramanian
> > ; Tejasree, Kondoj
> >
> > Subject: RE: [dpdk-dev] [PAT
; > To: Thomas Monjalon ; Trahe, Fiona
> >
> > Cc: dev@dpdk.org; Akhil Goyal ; Joseph, Anoob
> > ; De Lara Guarch, Pablo
> > ; Murthy, Nidadavolu
> > ; Jacob, Jerin
> > ; Athreya, Narayana Prasad
> > ; Dwivedi, Ankur
> > ; Dabilpuram, Nith
Jerin
> ; Athreya, Narayana Prasad
> ; Dwivedi, Ankur
> ; Dabilpuram, Nithin
> ; Jayaraman, Ragothaman
> ; Srinivasan, Srisivasubramanian
> ; Tejasree, Kondoj
>
> Subject: Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric
> capabilities
>
> Hi Fio
Hi Fiona,
We were following the QAT approach for defining the capabilities. OCTEON
TX crypto PMD has similar number of capabilities and QAT was the close
model that we could follow. I can see the advantages of the macro
approach, but that would give a checkpatch warning. Also, Thomas didn't
r
08/10/2018 17:59, Trahe, Fiona:
> Hi Akhil, Joseph, Thomas,
> Just spotted this now.
> See below.
>
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > 24/09/2018 13:36, Joseph, Anoob:
> > > Hi Fiona,
> > >
> > > Can you please comment on this?
> > >
> > > We are adding all capabilities of oc
De Lara Guarch, Pablo
> ;
> Murthy NSSR ; Jerin Jacob
> ; Narayana Prasad
> ; Ankur Dwivedi
> ; Nithin Dabilpuram
> ; Ragothaman Jayaraman
> ; Srisivasubramanian S
> ;
> Tejasree Kondoj
> Subject: Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric
> cap
24/09/2018 13:36, Joseph, Anoob:
> Hi Fiona,
>
> Can you please comment on this?
>
> We are adding all capabilities of octeontx-crypto PMD as a macro in
> otx_cryptodev_capabilites.h file and then we are using it from
> otx_cryptodev_ops.c. This is the approach followed by QAT crypto PMD. As
>
Hi Fiona,
Did you get a chance to look at this?
Thanks,
Anoob
On 24-09-2018 17:06, Joseph, Anoob wrote:
Hi Fiona,
Can you please comment on this?
We are adding all capabilities of octeontx-crypto PMD as a macro in
otx_cryptodev_capabilites.h file and then we are using it from
otx_cryptodev_
Hi Fiona,
Can you please comment on this?
We are adding all capabilities of octeontx-crypto PMD as a macro in
otx_cryptodev_capabilites.h file and then we are using it from
otx_cryptodev_ops.c. This is the approach followed by QAT crypto PMD. As
per my understanding, this is to ensure that cr
Hi Akhil,
On 17-09-2018 17:31, Akhil Goyal wrote:
External Email
diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c
b/drivers/crypto/octeontx/otx_cryptodev_ops.c
index d25f9c1..cc0030e 100644
--- a/drivers/crypto/octeontx/otx_cryptodev_ops.c
+++ b/drivers/crypto/octeontx/otx_cryptodev_o
diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c
b/drivers/crypto/octeontx/otx_cryptodev_ops.c
index d25f9c1..cc0030e 100644
--- a/drivers/crypto/octeontx/otx_cryptodev_ops.c
+++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c
@@ -10,9 +10,15 @@
#include "cpt_pmd_logs.h"
#include "ot
From: Murthy NSSR
This patch adds the symmetric algorithms capabilities
supported by octeontx crypto hardware.
Signed-off-by: Ankur Dwivedi
Signed-off-by: Anoob Joseph
Signed-off-by: Murthy NSSR
Signed-off-by: Nithin Dabilpuram
Signed-off-by: Ragothaman Jayaraman
Signed-off-by: Srisivasubra
15 matches
Mail list logo
