Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-16 Thread Ferruh Yigit
On 9/16/2019 4:45 PM, Andrew Rybchenko wrote: > On 9/16/19 4:22 PM, Ferruh Yigit wrote: >> On 9/13/2019 8:57 PM, Andrew Rybchenko wrote: >>> On 9/13/19 7:34 PM, Ferruh Yigit wrote: On 9/13/2019 5:05 PM, Andrew Rybchenko wrote: > On 9/13/19 6:39 PM, Ferruh Yigit wrote: >> On 9/9/2019 12

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-16 Thread Andrew Rybchenko
On 9/16/19 4:22 PM, Ferruh Yigit wrote: On 9/13/2019 8:57 PM, Andrew Rybchenko wrote: On 9/13/19 7:34 PM, Ferruh Yigit wrote: On 9/13/2019 5:05 PM, Andrew Rybchenko wrote: On 9/13/19 6:39 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: Enabling/disabling of promiscuous

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-16 Thread Ferruh Yigit
On 9/13/2019 8:57 PM, Andrew Rybchenko wrote: > On 9/13/19 7:34 PM, Ferruh Yigit wrote: >> On 9/13/2019 5:05 PM, Andrew Rybchenko wrote: >>> On 9/13/19 6:39 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: > Enabling/disabling of promiscuous mode is not always successf

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-15 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Andrew Rybchenko > Sent: Saturday, September 14, 2019 6:07 AM [...] > Subject: Re: [PATCH v2 04/13] ethdev: change promiscuous callbacks to > return status > > On 9/11/19 11:46 AM, Hyong Youb Kim (hyonkim) wrote: > >> -Original Message- > >> From: Andr

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/11/19 11:46 AM, Hyong Youb Kim (hyonkim) wrote: -Original Message- From: Andrew Rybchenko Sent: Monday, September 9, 2019 8:59 PM [...] Subject: [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status Enabling/disabling of promiscuous mode is not always successful

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/10/19 10:53 AM, Matan Azrad wrote: Hi Review for mlx5 part: Added not very important comment below. You can stay it as is if no new version will be created. Acked-by: Matan Azrad Thank you, will fix in the next version. Thanks. From: Andrew Rybchenko Enabling/disabling of promiscuo

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/13/19 7:56 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: Enabling/disabling of promiscuous mode is not always successful and it should be taken into account to be able to handle it properly. When correct return status is unclear from driver code, -EAGAIN is used. S

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/13/19 7:43 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: Enabling/disabling of promiscuous mode is not always successful and it should be taken into account to be able to handle it properly. When correct return status is unclear from driver code, -EAGAIN is used. S

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/13/19 7:34 PM, Ferruh Yigit wrote: On 9/13/2019 5:05 PM, Andrew Rybchenko wrote: On 9/13/19 6:39 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: Enabling/disabling of promiscuous mode is not always successful and it should be taken into account to be able to handle i

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Ferruh Yigit
On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: > Enabling/disabling of promiscuous mode is not always successful and > it should be taken into account to be able to handle it properly. > > When correct return status is unclear from driver code, -EAGAIN is used. > > Signed-off-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Ferruh Yigit
On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: > Enabling/disabling of promiscuous mode is not always successful and > it should be taken into account to be able to handle it properly. > > When correct return status is unclear from driver code, -EAGAIN is used. > > Signed-off-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Ferruh Yigit
On 9/13/2019 5:05 PM, Andrew Rybchenko wrote: > On 9/13/19 6:39 PM, Ferruh Yigit wrote: >> On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: >>> Enabling/disabling of promiscuous mode is not always successful and >>> it should be taken into account to be able to handle it properly. >>> >>> When correct

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Ferruh Yigit
On 9/13/2019 4:54 PM, Andrew Rybchenko wrote: > On 9/13/19 6:34 PM, Ferruh Yigit wrote: >> On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: >>> Enabling/disabling of promiscuous mode is not always successful and >>> it should be taken into account to be able to handle it properly. >>> >>> When correct

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/13/19 6:39 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: Enabling/disabling of promiscuous mode is not always successful and it should be taken into account to be able to handle it properly. When correct return status is unclear from driver code, -EAGAIN is used. S

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/13/19 6:34 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: Enabling/disabling of promiscuous mode is not always successful and it should be taken into account to be able to handle it properly. When correct return status is unclear from driver code, -EAGAIN is used. S

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Ferruh Yigit
On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: > Enabling/disabling of promiscuous mode is not always successful and > it should be taken into account to be able to handle it properly. > > When correct return status is unclear from driver code, -EAGAIN is used. > > Signed-off-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Ferruh Yigit
On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: > Enabling/disabling of promiscuous mode is not always successful and > it should be taken into account to be able to handle it properly. > > When correct return status is unclear from driver code, -EAGAIN is used. > > Signed-off-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-11 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, September 9, 2019 8:59 PM [...] > Subject: [PATCH v2 04/13] ethdev: change promiscuous callbacks to return > status > > Enabling/disabling of promiscuous mode is not always successful and > it should be taken into account to be

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-10 Thread Matan Azrad
Hi Review for mlx5 part: Added not very important comment below. You can stay it as is if no new version will be created. Acked-by: Matan Azrad Thanks. From: Andrew Rybchenko > Enabling/disabling of promiscuous mode is not always successful and > it should be taken into account to be able to

[dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-09 Thread Andrew Rybchenko
Enabling/disabling of promiscuous mode is not always successful and it should be taken into account to be able to handle it properly. When correct return status is unclear from driver code, -EAGAIN is used. Signed-off-by: Andrew Rybchenko --- app/test/virtual_pmd.c| 12 -