Re: [dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition

2020-04-09 Thread Lukasz Wojciechowski
W dniu 08.04.2020 o 19:47, Thomas Monjalon pisze: > 08/04/2020 18:15, Lukasz Wojciechowski: >> Hi Thomas, >> >> Before my patch there was just a definition: >> #define RTE_TEST_TRACE_FAILURE TEST_TRACE_FAILURE >> without #ifndef condition. >> >> It caused a build problem to me when working on sec

Re: [dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition

2020-04-08 Thread Thomas Monjalon
08/04/2020 18:15, Lukasz Wojciechowski: > Hi Thomas, > > Before my patch there was just a definition: > #define RTE_TEST_TRACE_FAILURE TEST_TRACE_FAILURE > without #ifndef condition. > > It caused a build problem to me when working on security test, which > uses both rte_test.h and test.h > As l

Re: [dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition

2020-04-08 Thread Lukasz Wojciechowski
Hi Thomas, Before my patch there was just a definition: #define RTE_TEST_TRACE_FAILURE TEST_TRACE_FAILURE without #ifndef condition. It caused a build problem to me when working on security test, which uses both rte_test.h and test.h As libraries should go first on the include list before local

Re: [dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition

2020-04-08 Thread Thomas Monjalon
08/04/2020 05:13, Lukasz Wojciechowski: > Wrap RTE_TEST_TRACE_FAILURE macro definition into #ifndef clause > as it might be already defined. I think it should not be defined at all. Why not including rte_test.h?

[dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition

2020-04-07 Thread Lukasz Wojciechowski
Wrap RTE_TEST_TRACE_FAILURE macro definition into #ifndef clause as it might be already defined. Fixes: 5afc521eac6a ("eal: add test assert macros") Cc: pbhagavat...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: Lukasz Wojciechowski --- app/test/test.h | 4 +++- 1 file changed, 3 inser