Re: [dpdk-dev] [PATCH v2 02/15] ethdev: add linkstatus get/set helper functions

2018-01-06 Thread Andrew Rybchenko
On 01/06/2018 05:24 PM, Stephen Hemminger wrote: On Sat, 6 Jan 2018 13:49:50 +0300 Andrew Rybchenko wrote: On 01/06/2018 04:06 AM, Stephen Hemminger wrote: +} + +void +_rte_eth_linkstatus_get(const struct rte_eth_dev *dev, + struct rte_eth_link *link) +{ + const ui

Re: [dpdk-dev] [PATCH v2 02/15] ethdev: add linkstatus get/set helper functions

2018-01-06 Thread Stephen Hemminger
On Sat, 6 Jan 2018 13:49:50 +0300 Andrew Rybchenko wrote: > On 01/06/2018 04:06 AM, Stephen Hemminger wrote: > > Many drivers are all doing copy/paste of the same code to atomically > > update the link status. Reduce duplication, and allow for future > > changes by having common function for this

Re: [dpdk-dev] [PATCH v2 02/15] ethdev: add linkstatus get/set helper functions

2018-01-06 Thread Andrew Rybchenko
On 01/06/2018 04:06 AM, Stephen Hemminger wrote: Many drivers are all doing copy/paste of the same code to atomically update the link status. Reduce duplication, and allow for future changes by having common function for this. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c

[dpdk-dev] [PATCH v2 02/15] ethdev: add linkstatus get/set helper functions

2018-01-05 Thread Stephen Hemminger
Many drivers are all doing copy/paste of the same code to atomically update the link status. Reduce duplication, and allow for future changes by having common function for this. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 35 +++ lib/librt