[dpdk-dev] [PATCH v2 01/17] ixgbe: use the right debug macro

2014-09-02 Thread Thomas Monjalon
2014-09-02 16:16, David Marchand: > >> /* Macros to check for invlaid function pointers. */ Invlaid is an invalid word ;) > >> -#defineFUNC_PTR_OR_ERR_RET(func, retval) do { \ > >> - if ((func) == NULL) { \ > >> - DEBUGOUT("%s:

[dpdk-dev] [PATCH v2 01/17] ixgbe: use the right debug macro

2014-09-02 Thread David Marchand
Hello Jay, On Tue, Sep 2, 2014 at 3:43 PM, Jay Rolette wrote: > > On Mon, Sep 1, 2014 at 5:24 AM, David Marchand > wrote: > >> >> diff --git a/lib/librte_pmd_ixgbe/ixgbe_bypass.c >> b/lib/librte_pmd_ixgbe/ixgbe_bypass.c >> index 1d21dc0..1a980b8 100644 >> --- a/lib/librte_pmd_ixgbe/ixgbe_bypas

[dpdk-dev] [PATCH v2 01/17] ixgbe: use the right debug macro

2014-09-02 Thread Jay Rolette
On Tue, Sep 2, 2014 at 9:21 AM, Thomas Monjalon wrote: > >> -#defineFUNC_PTR_OR_ERR_RET(func, retval) do { \ > > >> - if ((func) == NULL) { \ > > >> - DEBUGOUT("%s:%d function not supported\n", \ > > >> - _

[dpdk-dev] [PATCH v2 01/17] ixgbe: use the right debug macro

2014-09-02 Thread Jay Rolette
Hi David, A couple of minor comments inline below. Looks good otherwise. Jay On Mon, Sep 1, 2014 at 5:24 AM, David Marchand wrote: > - We should not use DEBUGOUT*/DEBUGFUNC macros in non-shared code. > These macros come as compat wrappers for shared code. > - We should avoid calling RTE_LOG d

[dpdk-dev] [PATCH v2 01/17] ixgbe: use the right debug macro

2014-09-01 Thread David Marchand
- We should not use DEBUGOUT*/DEBUGFUNC macros in non-shared code. These macros come as compat wrappers for shared code. - We should avoid calling RTE_LOG directly as pmd provides a wrapper for logs. Signed-off-by: David Marchand --- lib/librte_pmd_ixgbe/ixgbe_82599_bypass.c | 14 lib