Re: [dpdk-dev] [PATCH v2 01/12] ethdev: add port representor item to flow API

2021-10-10 Thread Ori Kam
Hi Ivan. > -Original Message- > From: Ivan Malov > Sent: Sunday, October 10, 2021 4:30 PM > Subject: Re: [PATCH v2 01/12] ethdev: add port representor item to flow API > > Hi Ori, > > Thanks a lot for reviewing this. > > On 10/10/2021 14:15, Ori Kam wrote: > > Hi Ivan, > > > >>From the

Re: [dpdk-dev] [PATCH v2 01/12] ethdev: add port representor item to flow API

2021-10-10 Thread Ori Kam
Hi Ivan, >From the new patches I saw you choose port_representor and represented_port Didn't we agree to go with ETHDEV_PORT and SHADOW_PORT? The only thing that worries me is that the naming are very easy to get wrong. port_representor and represented_port. Also there is an issue with wording if

Re: [dpdk-dev] [PATCH v2 01/12] ethdev: add port representor item to flow API

2021-10-10 Thread Ivan Malov
Hi Ori, On 10/10/2021 17:04, Ori Kam wrote: Hi Ivan. -Original Message- From: Ivan Malov Sent: Sunday, October 10, 2021 4:30 PM Subject: Re: [PATCH v2 01/12] ethdev: add port representor item to flow API Hi Ori, Thanks a lot for reviewing this. On 10/10/2021 14:15, Ori Kam wrote:

Re: [dpdk-dev] [PATCH v2 01/12] ethdev: add port representor item to flow API

2021-10-10 Thread Ivan Malov
Hi Ori, Thanks a lot for reviewing this. On 10/10/2021 14:15, Ori Kam wrote: Hi Ivan, From the new patches I saw you choose port_representor and represented_port Didn't we agree to go with ETHDEV_PORT and SHADOW_PORT? Yes, in the previous thread I suggested a different option. But I gave i

[dpdk-dev] [PATCH v2 01/12] ethdev: add port representor item to flow API

2021-10-09 Thread Ivan Malov
For use in "transfer" flows. Supposed to match traffic entering the embedded switch from the given ethdev. Must not be combined with direction attributes. Signed-off-by: Ivan Malov --- app/test-pmd/cmdline_flow.c | 27 ++ doc/guides/prog_guide/rte_flow.rst | 59