Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-22 Thread Bruce Richardson
On Fri, Jan 22, 2021 at 12:20:55AM +0100, Thomas Monjalon wrote: > 21/01/2021 16:15, Bruce Richardson: > > On Thu, Jan 21, 2021 at 10:36:18AM +0100, Thomas Monjalon wrote: > > > 21/01/2021 10:33, Bruce Richardson: > > > > On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote: > > > > > Is

Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-21 Thread Thomas Monjalon
21/01/2021 16:15, Bruce Richardson: > On Thu, Jan 21, 2021 at 10:36:18AM +0100, Thomas Monjalon wrote: > > 21/01/2021 10:33, Bruce Richardson: > > > On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote: > > > > Is rte_byteorder.h inclusion in rte_mbuf.h still necessary? > > > > > > > Good

Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-21 Thread Bruce Richardson
On Thu, Jan 21, 2021 at 10:36:18AM +0100, Thomas Monjalon wrote: > 21/01/2021 10:33, Bruce Richardson: > > On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote: > > > Is rte_byteorder.h inclusion in rte_mbuf.h still necessary? > > > > > Good question. The checks I was doing were only for

Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-21 Thread Bruce Richardson
On Thu, Jan 21, 2021 at 10:36:18AM +0100, Thomas Monjalon wrote: > 21/01/2021 10:33, Bruce Richardson: > > On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote: > > > Is rte_byteorder.h inclusion in rte_mbuf.h still necessary? > > > > > Good question. The checks I was doing were only for

Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-21 Thread Thomas Monjalon
21/01/2021 10:33, Bruce Richardson: > On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote: > > Is rte_byteorder.h inclusion in rte_mbuf.h still necessary? > > > Good question. The checks I was doing were only for missing headers. > Checking for superfluous headers is more complicated and

Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-21 Thread Bruce Richardson
On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote: > On Fri, Jan 15, 2021 at 12:11 PM Bruce Richardson > wrote: > > > > As a general principle, each header file should include any other > > headers it needs to provide data type definitions or macros. For > > example, any header using

Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-21 Thread David Marchand
On Fri, Jan 15, 2021 at 12:11 PM Bruce Richardson wrote: > > As a general principle, each header file should include any other > headers it needs to provide data type definitions or macros. For > example, any header using the uintX_t types in structures or function > prototypes should include "std

[dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-15 Thread Bruce Richardson
As a general principle, each header file should include any other headers it needs to provide data type definitions or macros. For example, any header using the uintX_t types in structures or function prototypes should include "stdint.h" to provide those type definitions. In practice, while many,