zh...@intel.com>>; Kwan,
Ngai-mint mailto:ngai-mint.k...@intel.com>>; Fornal,
Jakub mailto:jakub.for...@intel.com>>; Keller, Jacob E
mailto:jacob.e.kel...@intel.com>>; Jeff Zheng
mailto:jeff.zh...@silicom.co.il>>; Eyal Cohen
mailto:ey...@silicom.co.il>>
Subject: Re:
Zheng
; Eyal Cohen
Subject: Re: [dpdk-dev] [PATCH v2 0/7] support switch management
hi Xiao,
Thanks for your comments! I will fix them ASAP.
Best regards,
Xiaojun
From: Wang, Xiao W
Sent: Tuesday, February 11, 2020 6:31 PM
To: Xiaojun Liu
Cc: dev@dpdk.org
hi Xiao,
Thanks for your comments! I will fix them ASAP.
Best regards,
Xiaojun
From: Wang, Xiao W
Sent: Tuesday, February 11, 2020 6:31 PM
To: Xiaojun Liu
Cc: dev@dpdk.org ; Zhang, Qi Z ; Kwan,
Ngai-mint ; Fornal, Jakub ;
Keller, Jacob E ; Jeff Zheng
; Eyal C
Since this is a big code change, so just some general comments/suggestions for
your next version patch set:
- please clean up comments like "XXX" in the code.
- It's better to define MACRO for all register addrs and bit shift, please try
to avoid magic number (e.g. in the serdes part).
- There'r
Hi Xiao,
Thank you! I will update the commit log and prepare a document to describe the
design and implementation.
Best regards,
Xiaojun
-Original Message-
From: Wang, Xiao W [mailto:xiao.w.w...@intel.com]
Sent: Tuesday, January 21, 2020 10:53 AM
To: Xiaojun Liu
Cc: dev@dpdk.org; Zhang
Hi Xiaojun,
Could you please help to improve the commit logs of all the 7 patches? They
look very similar, and info like below is not very helpful for reviewer, since
we already know which file you are adding.
"To support switch management, add the following files:
Add fm10k/switch/fm10k_debug.h
To avoid configuration for both kernel driver
and userspace SDK outside DPDK, we add switch
management in FM10K DPDK PMD driver.
To enable switch management, you need add
CONFIG_RTE_FM10K_MANAGEMENT=y in
config/common_linux when building.
Xiaojun Liu (7):
net/fm10k: add i2c sbus registers defin
7 matches
Mail list logo
