Re: [dpdk-dev] [PATCH v2 0/6] fix ethdev device detach

2017-07-31 Thread Thomas Monjalon
> > Gaetan Rivet (6): > > ethdev: fix device state on detach > > ethdev: properly check detach capability > > net/mlx4: advertize the detach capability > > net/mlx5: advertize the detach capability > > app/testpmd: let the user know device detach failed > > doc: announce ethdev API chan

Re: [dpdk-dev] [PATCH v2 0/6] fix ethdev device detach

2017-07-31 Thread Adrien Mazarguil
On Wed, Jul 26, 2017 at 03:35:51PM +0200, Gaetan Rivet wrote: > Device detach in librte_ether is rough right now. > > - Device hotplug capability is not properly checked > - Device state should be set after a successful detach > - MLX drivers are lacking the relevant flag > - And this flag sho

Re: [dpdk-dev] [PATCH v2 0/6] fix ethdev device detach

2017-07-30 Thread Shachar Beiser
Tested-by : Shachar Beiser The bug is fixed and now there is no crash: testpmd> port stop all Stopping ports... Done testpmd> port close all Closing ports... Done testpmd> port detach 0 Detaching a port... Invalid port 0 Please close port first testpmd> show port info 0 Invalid port 0 Valid po

[dpdk-dev] [PATCH v2 0/6] fix ethdev device detach

2017-07-26 Thread Gaetan Rivet
Device detach in librte_ether is rough right now. - Device hotplug capability is not properly checked - Device state should be set after a successful detach - MLX drivers are lacking the relevant flag - And this flag should actually be removed, thus occuring an API change for v17.11. An ann