Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

2017-10-31 Thread Ferruh Yigit
On 10/31/2017 4:09 AM, Alejandro Lucero wrote: > I'm afraid the patch introduced a problem for the NFP PMD.  > > I have submitted a patch fixing it: "net/nfp: avoid unplug if multiport" Hi Alejandro, Sorry for this short notice, and thank you for the fix. > > Thanks > > On Mon, Oct 30, 2017 a

Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

2017-10-31 Thread Alejandro Lucero
I'm afraid the patch introduced a problem for the NFP PMD. I have submitted a patch fixing it: "net/nfp: avoid unplug if multiport" Thanks On Mon, Oct 30, 2017 at 9:45 AM, Alejandro Lucero < alejandro.luc...@netronome.com> wrote: > Hi guys, > > i have been on PTO since the 19th of October. > >

Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

2017-10-30 Thread Alejandro Lucero
Hi guys, i have been on PTO since the 19th of October. I will test this patch asap, but I'm aware this has already been accepted. On Wed, Oct 25, 2017 at 6:37 PM, Ferruh Yigit wrote: > On 10/24/2017 5:35 AM, Thomas Monjalon wrote: > > 24/10/2017 12:35, Gaetan Rivet: > >> Gaetan Rivet (6): > >>

Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

2017-10-25 Thread Ferruh Yigit
On 10/24/2017 5:35 AM, Thomas Monjalon wrote: > 24/10/2017 12:35, Gaetan Rivet: >> Gaetan Rivet (6): >> ethdev: do not rely on detachable flag in detach >> ethdev: remove detachable device flag >> pci: propagate PMD removal error value for unplug >> doc: follow detachable flag disappearance

Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

2017-10-25 Thread Ferruh Yigit
On 10/24/2017 4:56 PM, Ferruh Yigit wrote: > On 10/24/2017 3:35 AM, Gaetan Rivet wrote: >> This flag was deprecated in the previous release, and this is its removal. > > This change was in wait list, but it would be much more better if not received > just before rc2, but in early stages in the rel

Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

2017-10-24 Thread Ferruh Yigit
On 10/24/2017 3:35 AM, Gaetan Rivet wrote: > This flag was deprecated in the previous release, and this is its removal. This change was in wait list, but it would be much more better if not received just before rc2, but in early stages in the release, at worst before rc1. Although patch looks goo

Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

2017-10-24 Thread Thomas Monjalon
24/10/2017 12:35, Gaetan Rivet: > Gaetan Rivet (6): > ethdev: do not rely on detachable flag in detach > ethdev: remove detachable device flag > pci: propagate PMD removal error value for unplug > doc: follow detachable flag disappearance > doc: update detachable flag deprecation notice >

[dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

2017-10-24 Thread Gaetan Rivet
This flag was deprecated in the previous release, and this is its removal. We are going from an explicit support of device detach, to an implicit one, with specific checks in place for PMDs not supporting the feature. Attempting to Cc all relevant maintainers: Cc: Ajit Khaparde Cc: Alejandro Lu