Re: [dpdk-dev] [PATCH v2] vhost: improve dirty pages logging performance

2018-05-16 Thread Tiwei Bie
On Wed, May 16, 2018 at 09:49:45AM +0200, Maxime Coquelin wrote: > On 05/16/2018 08:21 AM, Tiwei Bie wrote: > > On Tue, May 15, 2018 at 07:30:21PM +0200, Maxime Coquelin wrote: [...] > > > @@ -309,7 +322,15 @@ struct virtio_net { > > > static __rte_always_inline void > > > vhost_set_bit(unsigne

Re: [dpdk-dev] [PATCH v2] vhost: improve dirty pages logging performance

2018-05-16 Thread Maxime Coquelin
On 05/16/2018 08:21 AM, Tiwei Bie wrote: On Tue, May 15, 2018 at 07:30:21PM +0200, Maxime Coquelin wrote: This patch caches all dirty pages logging until the used ring index is updated. These dirty pages won't be accessed by the guest as long as the host doesn't give them back to it by updatin

Re: [dpdk-dev] [PATCH v2] vhost: improve dirty pages logging performance

2018-05-15 Thread Tiwei Bie
On Tue, May 15, 2018 at 07:30:21PM +0200, Maxime Coquelin wrote: > This patch caches all dirty pages logging until the used ring index > is updated. These dirty pages won't be accessed by the guest as > long as the host doesn't give them back to it by updating the > index. > > The goal of this opt

[dpdk-dev] [PATCH v2] vhost: improve dirty pages logging performance

2018-05-15 Thread Maxime Coquelin
This patch caches all dirty pages logging until the used ring index is updated. These dirty pages won't be accessed by the guest as long as the host doesn't give them back to it by updating the index. The goal of this optimization is to fix a performance regression introduced when the vhost librar