Re: [dpdk-dev] [PATCH v2] vhost: fix shadow update

2020-04-17 Thread Maxime Coquelin
On 4/17/20 4:39 AM, Marvin Liu wrote: > Defer shadow ring update introduces functional issue which has been > described in Eugenio's fix patch. > > The current implementation of vhost_net in packed vring tries to fill > the shadow vector before send any actual changes to the guest. While > this

Re: [dpdk-dev] [PATCH v2] vhost: fix shadow update

2020-04-17 Thread Maxime Coquelin
On 4/17/20 4:39 AM, Marvin Liu wrote: > Defer shadow ring update introduces functional issue which has been > described in Eugenio's fix patch. > > The current implementation of vhost_net in packed vring tries to fill > the shadow vector before send any actual changes to the guest. While > this

[dpdk-dev] [PATCH v2] vhost: fix shadow update

2020-04-16 Thread Marvin Liu
Defer shadow ring update introduces functional issue which has been described in Eugenio's fix patch. The current implementation of vhost_net in packed vring tries to fill the shadow vector before send any actual changes to the guest. While this can be beneficial for the throughput, it conflicts w