Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-20 Thread Thomas Monjalon
19/01/2018 18:37, Maxime Coquelin: > > On 10/31/2017 04:59 PM, Jonas Pfefferle wrote: > > Check and report errors on open/read in noiommu check. > > > > Signed-off-by: Jonas Pfefferle > > --- > > lib/librte_eal/linuxapp/eal/eal_vfio.c | 29 + > > 1 file changed, 21

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-19 Thread Maxime Coquelin
On 10/31/2017 04:59 PM, Jonas Pfefferle wrote: Check and report errors on open/read in noiommu check. Signed-off-by: Jonas Pfefferle --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) I agree with the fix, Kerne

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-17 Thread Jonas Pfefferle
On Wed, 17 Jan 2018 09:55:37 +0100 Maxime Coquelin wrote: On 01/17/2018 09:48 AM, Jonas Pfefferle wrote:  On Tue, 16 Jan 2018 18:01:32 +0100  Maxime Coquelin wrote: Hi Jonas, On 01/16/2018 05:08 PM, Jonas Pfefferle wrote:   On Mon, 15 Jan 2018 17:11:58 +0100   Thomas Monjalon wrot

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-17 Thread Maxime Coquelin
On 01/17/2018 09:48 AM, Jonas Pfefferle wrote:  On Tue, 16 Jan 2018 18:01:32 +0100  Maxime Coquelin wrote: Hi Jonas, On 01/16/2018 05:08 PM, Jonas Pfefferle wrote:   On Mon, 15 Jan 2018 17:11:58 +0100   Thomas Monjalon wrote: 15/01/2018 13:22, Jonas Pfefferle:   On Sat, 13 Jan 2018

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-17 Thread Jonas Pfefferle
On Tue, 16 Jan 2018 18:01:32 +0100 Maxime Coquelin wrote: Hi Jonas, On 01/16/2018 05:08 PM, Jonas Pfefferle wrote:  On Mon, 15 Jan 2018 17:11:58 +0100  Thomas Monjalon wrote: 15/01/2018 13:22, Jonas Pfefferle:   On Sat, 13 Jan 2018 23:49:30 +0100   Thomas Monjalon wrote: > 13/01/201

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-16 Thread Maxime Coquelin
Hi Jonas, On 01/16/2018 05:08 PM, Jonas Pfefferle wrote:  On Mon, 15 Jan 2018 17:11:58 +0100  Thomas Monjalon wrote: 15/01/2018 13:22, Jonas Pfefferle:   On Sat, 13 Jan 2018 23:49:30 +0100   Thomas Monjalon wrote: > 13/01/2018 13:15, Burakov, Anatoly: >> On 11-Jan-18 11:45 PM, Thomas Mon

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-16 Thread Jonas Pfefferle
On Tue, 16 Jan 2018 10:07:51 + "Burakov, Anatoly" wrote: On 15-Jan-18 12:22 PM, Jonas Pfefferle wrote:  On Sat, 13 Jan 2018 23:49:30 +0100  Thomas Monjalon wrote: 13/01/2018 13:15, Burakov, Anatoly: On 11-Jan-18 11:45 PM, Thomas Monjalon wrote: > 07/11/2017 10:50, Jonas Pfefferle1:

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-16 Thread Jonas Pfefferle
On Mon, 15 Jan 2018 17:11:58 +0100 Thomas Monjalon wrote: 15/01/2018 13:22, Jonas Pfefferle: On Sat, 13 Jan 2018 23:49:30 +0100 Thomas Monjalon wrote: > 13/01/2018 13:15, Burakov, Anatoly: >> On 11-Jan-18 11:45 PM, Thomas Monjalon wrote: >> > 07/11/2017 10:50, Jonas Pfefferle1: >> >>>

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-16 Thread Burakov, Anatoly
On 15-Jan-18 12:22 PM, Jonas Pfefferle wrote:  On Sat, 13 Jan 2018 23:49:30 +0100  Thomas Monjalon wrote: 13/01/2018 13:15, Burakov, Anatoly: On 11-Jan-18 11:45 PM, Thomas Monjalon wrote: > 07/11/2017 10:50, Jonas Pfefferle1: >>> Is there something urgent for 17.11? >>> Or can it be refined

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-15 Thread Thomas Monjalon
15/01/2018 13:22, Jonas Pfefferle: > > On Sat, 13 Jan 2018 23:49:30 +0100 > Thomas Monjalon wrote: > > 13/01/2018 13:15, Burakov, Anatoly: > >> On 11-Jan-18 11:45 PM, Thomas Monjalon wrote: > >> > 07/11/2017 10:50, Jonas Pfefferle1: > >> >>> Is there something urgent for 17.11? > >> >>> Or ca

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-15 Thread Jonas Pfefferle
On Sat, 13 Jan 2018 23:49:30 +0100 Thomas Monjalon wrote: 13/01/2018 13:15, Burakov, Anatoly: On 11-Jan-18 11:45 PM, Thomas Monjalon wrote: > 07/11/2017 10:50, Jonas Pfefferle1: >>> Is there something urgent for 17.11? >>> Or can it be refined in 18.02? >> >> Nothing urgent. We can refine th

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-13 Thread Thomas Monjalon
13/01/2018 13:15, Burakov, Anatoly: > On 11-Jan-18 11:45 PM, Thomas Monjalon wrote: > > 07/11/2017 10:50, Jonas Pfefferle1: > >>> Is there something urgent for 17.11? > >>> Or can it be refined in 18.02? > >> > >> Nothing urgent. We can refine this for 18.02. > >> > >>> Anatoly, any thought? > > >

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-13 Thread Burakov, Anatoly
On 11-Jan-18 11:45 PM, Thomas Monjalon wrote: 07/11/2017 10:50, Jonas Pfefferle1: Is there something urgent for 17.11? Or can it be refined in 18.02? Nothing urgent. We can refine this for 18.02. Anatoly, any thought? Anatoly, Jonas, how do you want to proceed with this patch? I don't s

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-13 Thread Burakov, Anatoly
On 31-Oct-17 3:59 PM, Jonas Pfefferle wrote: Check and report errors on open/read in noiommu check. Signed-off-by: Jonas Pfefferle --- LGTM Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-11 Thread Thomas Monjalon
07/11/2017 10:50, Jonas Pfefferle1: > Thomas Monjalon wrote on 11/07/2017 10:40:15 AM: > > > From: Thomas Monjalon > > To: Jonas Pfefferle1 , anatoly.bura...@intel.com > > Cc: dev@dpdk.org > > Date: 11/07/2017 10:40 AM > > Subject: Re: [dpdk-dev] [PATCH v2

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2017-11-07 Thread Jonas Pfefferle1
Thomas Monjalon wrote on 11/07/2017 10:40:15 AM: > From: Thomas Monjalon > To: Jonas Pfefferle1 , anatoly.bura...@intel.com > Cc: dev@dpdk.org > Date: 11/07/2017 10:40 AM > Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling > > 07/11/2017 10:05, Jonas P

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2017-11-07 Thread Thomas Monjalon
07/11/2017 10:05, Jonas Pfefferle1: > Thomas Monjalon wrote on 11/06/2017 09:25:15 PM: > > > From: Thomas Monjalon > > To: Jonas Pfefferle , anatoly.bura...@intel.com > > Cc: dev@dpdk.org > > Date: 11/06/2017 09:55 PM > > Subject: Re: [dpdk-dev] [PATCH v2

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2017-11-07 Thread Jonas Pfefferle1
Thomas Monjalon wrote on 11/06/2017 09:25:15 PM: > From: Thomas Monjalon > To: Jonas Pfefferle , anatoly.bura...@intel.com > Cc: dev@dpdk.org > Date: 11/06/2017 09:55 PM > Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling > > 31/10/2017 16:59, Jonas Pfe

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2017-11-06 Thread Thomas Monjalon
31/10/2017 16:59, Jonas Pfefferle: > Check and report errors on open/read in noiommu check. > > Signed-off-by: Jonas Pfefferle I cannot decide to apply this patch as it does not explain what it is fixing, and as it is not reviewed.

[dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2017-10-31 Thread Jonas Pfefferle
Check and report errors on open/read in noiommu check. Signed-off-by: Jonas Pfefferle --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linuxapp/ea