[dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode

2016-01-27 Thread David Marchand
On Wed, Jan 27, 2016 at 11:12 AM, Thomas Monjalon wrote: > 2016-01-27 10:08, Burakov, Anatoly: >> > Why a new file for these functions? >> >> Well, my thought was to make future extensions easier by way of avoiding >> mixing irrelevant and/or general code with driver-specific code. I can >> chan

[dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode

2016-01-27 Thread Thomas Monjalon
2016-01-27 10:08, Burakov, Anatoly: > > Why a new file for these functions? > > Well, my thought was to make future extensions easier by way of avoiding > mixing irrelevant and/or general code with driver-specific code. I can change > it back if that's not OK. No strong opinion here. David?

[dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode

2016-01-27 Thread Burakov, Anatoly
> >> > Why a new file for these functions? > >> > >> Well, my thought was to make future extensions easier by way of > avoiding mixing irrelevant and/or general code with driver-specific code. I > can > change it back if that's not OK. > > > > No strong opinion here. > > David? > > Hum, no strong

[dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode

2016-01-27 Thread Burakov, Anatoly
Hi Thomas, > The comments "function pointer typedef" or "structure to hold" don't > bring new information. Please keep it short. I'll fix that and submit a v3, thanks. > Why a new file for these functions? Well, my thought was to make future extensions easier by way of avoiding mixing irreleva

[dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode

2016-01-27 Thread Thomas Monjalon
Hi Anatoly, Few small comments. The comments "function pointer typedef" or "structure to hold" don't bring new information. Please keep it short. 2016-01-13 12:36, Anatoly Burakov: > +/* function pointer typedef for DMA mapping functions */ -> DMA mapping function type It would be relevant

[dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode

2016-01-14 Thread Burakov, Anatoly
Hi Stephen, > > +/* IOMMU types we support */ > > +static const struct vfio_iommu_type iommu_types[] = { > > + /* x86 IOMMU, otherwise known as type 1 */ > > + { VFIO_TYPE1_IOMMU, "Type 1", > &vfio_iommu_type1_dma_map}, > > + /* IOMMU-less mode */ > > + { VF

[dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode

2016-01-13 Thread Anatoly Burakov
This commit is adding a generic mechanism to support multiple IOMMU types. For now, it's only type 1 (x86 IOMMU) and no-IOMMU (a special VFIO mode that doesn't use IOMMU at all), but it's easily extended by adding necessary definitions into eal_pci_init.h and a DMA mapping function to eal_pci_vfio_

[dpdk-dev] [PATCH v2] vfio: Support for no-IOMMU mode

2016-01-13 Thread Stephen Hemminger
On Wed, 13 Jan 2016 12:36:09 + Anatoly Burakov wrote: > +/* IOMMU types we support */ > +static const struct vfio_iommu_type iommu_types[] = { > + /* x86 IOMMU, otherwise known as type 1 */ > + { VFIO_TYPE1_IOMMU, "Type 1", &vfio_iommu_type1_dma_map}, > + /