Re: [dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

2019-05-09 Thread Thomas Monjalon
09/05/2019 01:01, Carrillo, Erik G: > I like this idea; thanks for the suggestion. I went ahead and submitted a > new version > of this patch with this approach. It's dependent on one other new patch that > allows > secondary processes to reserve the memzone. I also submitted a deprecation >

Re: [dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

2019-05-08 Thread Carrillo, Erik G
> -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, May 8, 2019 3:50 AM > To: Carrillo, Erik G ; rsanf...@akamai.com; > tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [PATCH v2] timer: fix resource leak in finalize > > On 07-May-19 11:04 PM, Carrillo, Erik G wrote: >

Re: [dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

2019-05-08 Thread Burakov, Anatoly
On 07-May-19 11:04 PM, Carrillo, Erik G wrote: Hi Anatoly, Thanks for the review. Comments in-line: <...snipped...> #define RTE_MAX_DATA_ELS 64 +static const struct rte_memzone *rte_timer_data_mz; static +rte_atomic16_t *rte_timer_mz_refcnt; static struct rte_timer_data *rte_timer_data

Re: [dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

2019-05-07 Thread Carrillo, Erik G
Hi Anatoly, Thanks for the review. Comments in-line: <...snipped...> > > #define RTE_MAX_DATA_ELS 64 > > +static const struct rte_memzone *rte_timer_data_mz; static > > +rte_atomic16_t *rte_timer_mz_refcnt; > > static struct rte_timer_data *rte_timer_data_arr; > > static const uint32_t de

Re: [dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

2019-05-07 Thread Burakov, Anatoly
On 03-May-19 11:54 PM, Erik Gabriel Carrillo wrote: The finalize function should free the memzone created in the init function, rather than freeing the allocation the memzone references, otherwise a memzone descriptor can be leaked. Fixes: c0749f7096c7 ("timer: allow management in shared memory"

[dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

2019-05-03 Thread Erik Gabriel Carrillo
The finalize function should free the memzone created in the init function, rather than freeing the allocation the memzone references, otherwise a memzone descriptor can be leaked. Fixes: c0749f7096c7 ("timer: allow management in shared memory") Signed-off-by: Erik Gabriel Carrillo --- changes i