Re: [dpdk-dev] [PATCH v2] pci: keep API compatibility with mmap values

2020-07-11 Thread Thomas Monjalon
10/07/2020 23:07, Dmitry Kozlyuk: > On Fri, 10 Jul 2020 22:40:34 +0200, Thomas Monjalon wrote: > > The function pci_map_resource() returns MAP_FAILED in case of error. > > When replacing the call to mmap() by rte_mem_map(), > > the error code became NULL, breaking the API. > > This function is prob

Re: [dpdk-dev] [PATCH v2] pci: keep API compatibility with mmap values

2020-07-11 Thread Thomas Monjalon
tal...@mellanox.com > Subject: [dpdk-dev] [PATCH v2] pci: keep API compatibility with mmap values > > The function pci_map_resource() returns MAP_FAILED in case of error. > When replacing the call to mmap() by rte_mem_map(), the error code became > NULL, breaking the API. > This fu

Re: [dpdk-dev] [PATCH v2] pci: keep API compatibility with mmap values

2020-07-10 Thread Ma, LihongX
; Richardson, Bruce ; dmitry.kozl...@gmail.com; navas...@linux.microsoft.com; dmit...@microsoft.com; Kadam, Pallavi ; tal...@mellanox.com Subject: [dpdk-dev] [PATCH v2] pci: keep API compatibility with mmap values The function pci_map_resource() returns MAP_FAILED in case of error. When replacing the call

Re: [dpdk-dev] [PATCH v2] pci: keep API compatibility with mmap values

2020-07-10 Thread Dmitry Kozlyuk
On Fri, 10 Jul 2020 22:40:34 +0200, Thomas Monjalon wrote: > The function pci_map_resource() returns MAP_FAILED in case of error. > When replacing the call to mmap() by rte_mem_map(), > the error code became NULL, breaking the API. > This function is probably not used outside of DPDK, > but it is s

[dpdk-dev] [PATCH v2] pci: keep API compatibility with mmap values

2020-07-10 Thread Thomas Monjalon
The function pci_map_resource() returns MAP_FAILED in case of error. When replacing the call to mmap() by rte_mem_map(), the error code became NULL, breaking the API. This function is probably not used outside of DPDK, but it is still a problem for two reasons: - the deprecation process was