Re: [dpdk-dev] [PATCH v2] net/vmxnet3: fix dereference before null check

2017-10-02 Thread Ferruh Yigit
On 9/29/2017 2:04 PM, Michal Jastrzebski wrote: > Coverity reports check_after_deref: > Null-checking rq suggests that it may be null, but it > has already been dereferenced on all paths leading to > the check. > This patch removes NULL checking of "rq" from function > vmxnet3_dev_rx_queue_reset as

Re: [dpdk-dev] [PATCH v2] net/vmxnet3: fix dereference before null check

2017-10-02 Thread Jastrzebski, MichalX K
> -Original Message- > From: Jastrzebski, MichalX K > Sent: Friday, September 29, 2017 3:04 PM > To: skh...@vmware.com > Cc: dev@dpdk.org; Jain, Deepak K ; Yigit, Ferruh > ; Jastrzebski, MichalX K > ; yongw...@vmware.com; > sta...@dpdk.org; Kulasek, TomaszX > Subject: [PATCH v2] net/vmxnet

[dpdk-dev] [PATCH v2] net/vmxnet3: fix dereference before null check

2017-09-29 Thread Michal Jastrzebski
Coverity reports check_after_deref: Null-checking rq suggests that it may be null, but it has already been dereferenced on all paths leading to the check. This patch removes NULL checking of "rq" from function vmxnet3_dev_rx_queue_reset as it is already checked against NULL one level up the callsta